Skip to content

[PWGHF] Fix HF event selection initialization and add explicit casts for BC table #14315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgrosa merged 1 commit into from
Dec 21, 2025
Merged

[PWGHF] Fix HF event selection initialization and add explicit casts for BC table #14315

fgrosa merged 1 commit into from
Dec 21, 2025
+3 −3

Conversation

@fgrosa
Copy link
Collaborator

@fgrosa fgrosa commented Dec 21, 2025 •
edited
Loading

No description provided.

@fgrosa fgrosa changed the title Fix HF event selection initialization and add explicit casts for BC t… Fix HF event selection initialization and add explicit casts for BC table Dec 21, 2025
@github-actions github-actions bot added the pwghf PWG-HF label Dec 21, 2025
@github-actions
Copy link

github-actions bot commented Dec 21, 2025

O2 linter results: ❌ 16 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Fix HF event selection initialization and add explicit casts for BC table [PWGHF] Fix HF event selection initialization and add explicit casts for BC t… Dec 21, 2025
@github-actions github-actions bot changed the title [PWGHF] Fix HF event selection initialization and add explicit casts for BC t… [PWGHF] Fix HF event selection initialization and add explicit casts for BC table Dec 21, 2025
@fgrosa fgrosa enabled auto-merge (squash) December 21, 2025 16:32
alibuild
alibuild approved these changes Dec 21, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @fgrosa.

@fgrosa fgrosa merged commit f799743 into AliceO2Group:master Dec 21, 2025
16 of 17 checks passed
vkucera
vkucera reviewed Dec 21, 2025
View reviewed changes
PWGHF/Tasks/taskMcValidation.cxx
histContributors->GetXaxis()->SetBinLabel(1, "correct MC collision");
histContributors->GetXaxis()->SetBinLabel(2, "wrong MC collision");
hfEvSel.addHistograms(registry); // collision monitoring
hfEvSel.init(registry, nullptr); // collision monitoring
Copy link
Collaborator

@vkucera vkucera Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nullptr is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@alibuild alibuild alibuild approved these changes

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fgrosa @alibuild @vkucera