[PWGCF] Add 2D pt Efficiency calculation #14604
Conversation
huinaibing
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#14604
| case MyFunctionName::funcProcessData: | ||
| this->registry.fill(HIST("hEventCount/processData"), position); | ||
| break; | ||
| case MyFunctionName::funcDetectorPidQA: | ||
| this->registry.fill(HIST("hEventCount/detectorPidQA"), position); | ||
| break; | ||
| case MyFunctionName::funcFillCorrectionGraph: | ||
| this->registry.fill(HIST("hEventCount/fillCorrectionGraph"), position); | ||
| break; | ||
| case MyFunctionName::funcProcessReco: | ||
| this->registry.fill(HIST("hEventCount/processReco"), position); | ||
| break; | ||
| case MyFunctionName::funcProcessSim: | ||
| this->registry.fill(HIST("hEventCount/processSim"), position); | ||
| break; |
There was a problem hiding this comment.
Why using this? It is not needed and creates the impression that actually it is
| return false; | ||
| } | ||
| registry.fill(HIST("hEventCount"), 2.5); | ||
| this->fillEventCountHelper(funcName, 2.5); |
| if (cfgOutputrunbyrun) { | ||
| // hist for NUA | ||
| registry.add("correction/hRunNumberPhiEtaVertex", "", {HistType::kTHnSparseF, {cfgaxisRun, cfgaxisPhi, cfgaxisEta, cfgaxisVertex}}); | ||
| registry.add("correction/hRunNumberPhiEtaVertex", "", {HistType::kTHnSparseD, {cfgaxisRun, cfgaxisPhi, cfgaxisEta, cfgaxisVertex}}); |
There was a problem hiding this comment.
Are you sure you want this leap in memory usage?
Do you actually need a double per bin?
There was a problem hiding this comment.
Thank you for your comment, Professor. I’m used to writing Python, so I instinctively added this-> when coding in C++. This is indeed unnecessary. Also, the change from thnsparsef to thnspared was made during my local testing – the order of magnitude does not appear to reach the limit of float, and I will correct these details in the next PR.
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my comments for future iterations
3 participants
processReco&&processSim) for 2D Eff(pt, cent) calculationsetCurrentParticleWeightto apply 2D Eff