Skip to content

[PWGEM] PhotonMeson: Add basic EMCal QA to EMCPhotonCut #14785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhemmer-cern merged 2 commits into from
Feb 4, 2026
Merged

[PWGEM] PhotonMeson: Add basic EMCal QA to EMCPhotonCut #14785

mhemmer-cern merged 2 commits into from
Feb 4, 2026
+158 −12

Conversation

@mhemmer-cern
Copy link
Collaborator

@mhemmer-cern mhemmer-cern commented Feb 3, 2026

  • Add basic cluster QA to EMCPhotonCut class when using AreSelectedRunning function. QA is not enabled for IsSelected since IsSelected is considered legecy code that should slowly be removed.

@mhemmer-cern
[PWGEM] PhotonMeson: Add basic EMCal QA to EMCPhotonCut
53eaaa7 
- Add basic cluster QA to EMCPhotonCut class when using `AreSelectedRunning` function. QA is not enabled for `IsSelected` since IsSelected is considered legecy code that should slowly be removed.
@github-actions github-actions bot added the pwgem label Feb 3, 2026
@mhemmer-cern mhemmer-cern added the photon Photon and neutral meson PAG label label Feb 3, 2026
@mhemmer-cern mhemmer-cern enabled auto-merge (squash) February 3, 2026 16:46
alibuild
alibuild previously approved these changes Feb 3, 2026
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@alibuild
Copy link
Collaborator

alibuild commented Feb 3, 2026

Error while checking build/O2Physics/o2 for 53eaaa7 at 2026-02-03 19:56:

## sw/BUILD/O2Physics-latest/log
/sw/slc9_x86-64/O2/daily-20260203-0000-local1/include/Framework/HistogramRegistry.h:447:135: error: 'this' pointer is null [-Werror=nonnull]
/sw/slc9_x86-64/O2/daily-20260203-0000-local1/include/Framework/HistogramRegistry.h:447:135: error: 'this' pointer is null [-Werror=nonnull]
/sw/slc9_x86-64/O2/daily-20260203-0000-local1/include/Framework/HistogramRegistry.h:447:135: error: 'this' pointer is null [-Werror=nonnull]
/sw/slc9_x86-64/O2/daily-20260203-0000-local1/include/Framework/HistogramRegistry.h:447:135: error: 'this' pointer is null [-Werror=nonnull]
ninja: build stopped: subcommand failed.

Full log here.

@mhemmer-cern mhemmer-cern disabled auto-merge February 4, 2026 08:47
@mhemmer-cern mhemmer-cern enabled auto-merge (squash) February 4, 2026 08:56
alibuild
alibuild approved these changes Feb 4, 2026
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@mhemmer-cern mhemmer-cern merged commit 90f1da0 into AliceO2Group:master Feb 4, 2026
12 checks passed
@mhemmer-cern mhemmer-cern deleted the emc-cluster-qa branch February 4, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@m-c-danisch m-c-danisch Awaiting requested review from m-c-danisch m-c-danisch is a code owner

@novitzky novitzky Awaiting requested review from novitzky novitzky is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

Assignees

No one assigned

Labels

photon Photon and neutral meson PAG label pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhemmer-cern @alibuild