[ALICE3] Add improved LUT format#15711
Draft
aalkin wants to merge 11 commits intoAliceO2Group:masterfrom
Draft
Conversation
github-actions
bot
changed the title
|
O2 linter results: ❌ 10 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @njacazio,
This is the replacement for TrackSmearer and LUTWriter, using a flattened data structure FlatLutData. It should be functionally identical (needs validation), but in addition it allows to construct the TrackSmearer as a view over shared memory instead of copying memory or loading the LUT from file. From the API standpoint, you should be able to use the new TrackSmearer in exactly the same way as the old one, and after some additional developments in O2 you can switch to the view approach.