Skip to content

[PWGLF] Added a new table producer; Cascadederivedqaanalysis#15736

Open
BilgeJinONEN wants to merge 11 commits intoAliceO2Group:masterfrom
BilgeJinONEN:master
Open

[PWGLF] Added a new table producer; Cascadederivedqaanalysis#15736
BilgeJinONEN wants to merge 11 commits intoAliceO2Group:masterfrom
BilgeJinONEN:master

Conversation

@BilgeJinONEN
Copy link
Copy Markdown

@BilgeJinONEN BilgeJinONEN commented Apr 12, 2026

I change the iterator structure for MC because we were gettıng the error of they were not sorted.

@github-actions github-actions bot added the pwglf label Apr 12, 2026
@github-actions github-actions bot changed the title PWGLF: Grouping changes are added [PWGLF] Grouping changes are added Apr 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026 •
edited
Loading

O2 linter results: ❌ 46 errors, ⚠️ 1 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Apr 12, 2026
Merged
@vkucera vkucera marked this pull request as draft April 12, 2026 22:17
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 12, 2026

Please read the contribution guidelines.

BilgeJinONEN and others added 4 commits April 13, 2026 22:36
@BilgeJinONEN BilgeJinONEN marked this pull request as ready for review April 13, 2026 20:44
@alibuild alibuild mentioned this pull request Apr 13, 2026
Merged
@vkucera vkucera marked this pull request as draft April 13, 2026 20:45
@BilgeJinONEN
Merge pull request #2 from alibuild/alibot-cleanup-15736
0406b6e 
[PWGLF] Please consider the following formatting changes to AliceO2Group#15736
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 13, 2026

  • Don't open your PR as ready for review if it doesn't pass the required tests.
  • Why are you adding a new workflow while saying in the PR title that you only add changes?
  • Why is the code you are adding authored by someone else?

@BilgeJinONEN BilgeJinONEN changed the title [PWGLF] Grouping changes are added [PWGLF] Added a new table producer; Cascadederivedqaanalysis Apr 13, 2026
@BilgeJinONEN BilgeJinONEN marked this pull request as ready for review April 13, 2026 20:55
romainschotter
romainschotter previously approved these changes Apr 13, 2026
View reviewed changes
@romainschotter romainschotter enabled auto-merge (squash) April 13, 2026 20:56
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 13, 2026

@romainschotter There is a number of issues with this PR, a major one being an obviously wrong list of includes.
Why is this being merged without a proper review?

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 13, 2026

Error while checking build/O2Physics/o2 for 0406b6e at 2026-04-13 23:07:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Strangeness/cascderivedqaanalysis.cxx:594:77: error: unused parameter 'cascMCCores' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@romainschotter romainschotter disabled auto-merge April 13, 2026 22:20
@romainschotter romainschotter enabled auto-merge (squash) April 13, 2026 22:20
@alibuild alibuild mentioned this pull request Apr 13, 2026
Merged
romainschotter
romainschotter previously approved these changes Apr 13, 2026
View reviewed changes
@romainschotter romainschotter marked this pull request as draft April 13, 2026 22:22
auto-merge was automatically disabled April 13, 2026 22:22

Pull request was converted to draft

@BilgeJinONEN BilgeJinONEN marked this pull request as ready for review April 13, 2026 23:03
@lhusova lhusova enabled auto-merge (squash) April 14, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhusova lhusova lhusova approved these changes

@romainschotter romainschotter romainschotter left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BilgeJinONEN @vkucera @alibuild @lhusova @romainschotter