Skip to content

[PWGLF] Fix histogram getter #15906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romainschotter merged 2 commits into from
Apr 21, 2026
+12 −12
Merged

[PWGLF] Fix histogram getter #15906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1067c5e
Fix histogram getter
romainschotter Apr 21, 2026
8b0e5e0
Fix processMonteCarlo and processGenerated
romainschotter Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions PWGLF/Tasks/QC/v0cascadesqa.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,14 +427,14 @@

if (isMC) {
histos.add("histos_V0/GeneratedV0s", "GeneratedV0s", kTH3D, {{3, 0.0f, 3.0f}, axisConfigurations.axisPt, axisConfigurations.axisV0Radius});
histos.get<TH1>(HIST("histos_V0/GeneratedV0s"))->GetXaxis()->SetBinLabel(1, "K^{0}_{S}");
histos.get<TH1>(HIST("histos_V0/GeneratedV0s"))->GetXaxis()->SetBinLabel(2, "#Lambda");
histos.get<TH1>(HIST("histos_V0/GeneratedV0s"))->GetXaxis()->SetBinLabel(3, "#bar{#Lambda}");
histos.get<TH3>(HIST("histos_V0/GeneratedV0s"))->GetXaxis()->SetBinLabel(1, "K^{0}_{S}");
histos.get<TH3>(HIST("histos_V0/GeneratedV0s"))->GetXaxis()->SetBinLabel(2, "#Lambda");
histos.get<TH3>(HIST("histos_V0/GeneratedV0s"))->GetXaxis()->SetBinLabel(3, "#bar{#Lambda}");
histos.add("histos_Casc/GeneratedCascades", "GeneratedCascades", kTH3D, {{4, 0.0f, 4.0f}, axisConfigurations.axisPtCasc, axisConfigurations.axisCascRadius});
histos.get<TH1>(HIST("histos_Casc/GeneratedCascades"))->GetXaxis()->SetBinLabel(1, "#Xi^{#minus}");
histos.get<TH1>(HIST("histos_Casc/GeneratedCascades"))->GetXaxis()->SetBinLabel(2, "#bar{#Xi}^{+}");
histos.get<TH1>(HIST("histos_Casc/GeneratedCascades"))->GetXaxis()->SetBinLabel(3, "#Omega^{#minus}");
histos.get<TH1>(HIST("histos_Casc/GeneratedCascades"))->GetXaxis()->SetBinLabel(4, "#bar{#Omega}^{+}");
histos.get<TH3>(HIST("histos_Casc/GeneratedCascades"))->GetXaxis()->SetBinLabel(1, "#Xi^{#minus}");
histos.get<TH3>(HIST("histos_Casc/GeneratedCascades"))->GetXaxis()->SetBinLabel(2, "#bar{#Xi}^{+}");
histos.get<TH3>(HIST("histos_Casc/GeneratedCascades"))->GetXaxis()->SetBinLabel(3, "#Omega^{#minus}");
histos.get<TH3>(HIST("histos_Casc/GeneratedCascades"))->GetXaxis()->SetBinLabel(4, "#bar{#Omega}^{+}");

histos.add("histos_V0/InvMassK0sTrue", "InvMassK0sTrue", {HistType::kTH3F, {{100, 0.0f, 10.0f}, {100, 0.f, 50.f}, {200, 0.4f, 0.6f}}});
histos.add("histos_V0/InvMassLambdaTrue", "InvMassLambdaTrue", {HistType::kTH3F, {{100, 0.0f, 10.0f}, {100, 0.f, 50.f}, {200, 1.07f, 1.17f}}});
Expand Down Expand Up @@ -646,7 +646,7 @@
return false;

// armenteros (for K0s only)
if (v0Type == kK0s && v0Selections.armPodCut > 1e-4 && v0.qtarm() * v0Selections.armPodCut < std::abs(v0.alpha()))

Check failure on line 649 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;

// rapidity
Expand Down Expand Up @@ -760,26 +760,26 @@

// TOF Nsigma
if (v0Type == kK0s) {
if (v0Selections.tofPidNsigmaCutK0Pi < 1e+5 && v0.positiveHasTOF() && std::fabs(v0.tofNSigmaK0PiPlus()) > v0Selections.tofPidNsigmaCutK0Pi) {

Check failure on line 763 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
if (v0Selections.tofPidNsigmaCutK0Pi < 1e+5 && v0.negativeHasTOF() && std::fabs(v0.tofNSigmaK0PiMinus()) > v0Selections.tofPidNsigmaCutK0Pi) {

Check failure on line 766 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
}
if (v0Type == kLambda) {
if (v0Selections.tofPidNsigmaCutLaPr < 1e+5 && v0.positiveHasTOF() && std::fabs(v0.tofNSigmaLaPr()) > v0Selections.tofPidNsigmaCutLaPr) {

Check failure on line 771 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
if (v0Selections.tofPidNsigmaCutLaPi < 1e+5 && v0.negativeHasTOF() && std::fabs(v0.tofNSigmaLaPi()) > v0Selections.tofPidNsigmaCutLaPi) {

Check failure on line 774 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
}
if (v0Type == kAntiLambda) {
if (v0Selections.tofPidNsigmaCutLaPi < 1e+5 && v0.positiveHasTOF() && std::fabs(v0.tofNSigmaLaPi()) > v0Selections.tofPidNsigmaCutLaPi) {

Check failure on line 779 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
if (v0Selections.tofPidNsigmaCutLaPr < 1e+5 && v0.negativeHasTOF() && std::fabs(v0.tofNSigmaLaPr()) > v0Selections.tofPidNsigmaCutLaPr) {

Check failure on line 782 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
}
Expand All @@ -793,7 +793,7 @@
}

int posTRDhits = 0, negTRDhits = 0;
for (unsigned int i = 0; i <= 5; i++) {

Check failure on line 796 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (posTrackExtra.trdPattern() & (1 << i)) {
posTRDhits++;
}
Expand Down Expand Up @@ -1001,7 +1001,7 @@
}

int bachTRDhits = 0, posTRDhits = 0, negTRDhits = 0;
for (unsigned int i = 0; i <= 5; i++) {

Check failure on line 1004 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (bachTrackExtra.trdPattern() & (1 << i)) {
bachTRDhits++;
}
Expand Down Expand Up @@ -1260,7 +1260,7 @@
////////// QA - MC /////////////
////////////////////////////////

void processMonteCarlo(soa::Join<aod::Collisions, aod::EvSels, aod::PVMults, aod::McCollisionLabels>::iterator const& collision, soa::Join<aod::McCollisions, aod::MultsExtraMC> const&, soa::Join<aod::V0Datas, aod::V0TOFPIDs, aod::V0TOFNSigmas, aod::V0CoreMCLabels> const& fullV0s, soa::Join<aod::V0MCDatas, aod::V0MCCollRefs> const&, soa::Join<aod::CascDatas, aod::CascTOFPIDs, aod::CascTOFNSigmas, aod::CascCoreMCLabels> const& fullCascades, soa::Join<aod::CascMCDatas, aod::CascMCCollRefs> const&, DaughterTracks const&, aod::BCsWithTimestamps const&)
void processMonteCarlo(soa::Join<aod::Collisions, aod::EvSels, aod::PVMults, aod::McCollisionLabels>::iterator const& collision, soa::Join<aod::McCollisions, aod::MultsExtraMC> const&, soa::Join<aod::V0Datas, aod::V0TOFPIDs, aod::V0TOFNSigmas, aod::V0CoreMCLabels> const& fullV0s, soa::Join<aod::V0MCCores, aod::V0MCCollRefs> const&, soa::Join<aod::CascDatas, aod::CascTOFPIDs, aod::CascTOFNSigmas, aod::CascCoreMCLabels> const& fullCascades, soa::Join<aod::CascMCCores, aod::CascMCCollRefs> const&, DaughterTracks const&, aod::BCsWithTimestamps const&)
{
if (!isEventAccepted(collision, false)) {
return;
Expand All @@ -1275,7 +1275,7 @@
if (eventSelections.requireINEL0 && mcCollision.multMCNParticlesEta10() < 1) {
return;
}
if (eventSelections.requireINEL1 && mcCollision.multMCNParticlesEta10() < 2) {

Check failure on line 1278 in PWGLF/Tasks/QC/v0cascadesqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return;
}

Expand Down Expand Up @@ -1315,12 +1315,12 @@
if (!casc.has_cascMCCore())
continue;

auto cascMC = casc.template cascMCCore_as<soa::Join<aod::CascMCDatas, aod::CascMCCollRefs>>();
auto cascMC = casc.template cascMCCore_as<soa::Join<aod::CascMCCores, aod::CascMCCollRefs>>();

histos.fill(HIST("histos_Casc/QA_CascadeCandidates"), 0.5);

if (isCascadeSelected(casc, collision, cascMC.rapidityMC(0), kXiM)) {
histos.fill(HIST("histos_Casc/QA_CascCandidates"), 1.5);
histos.fill(HIST("histos_Casc/QA_CascadeCandidates"), 1.5);
if (checkCascadeMCAssociation(cascMC, kXiM)) {
histos.fill(HIST("histos_Casc/QA_CascadeCandidates"), 2.5);
histos.fill(HIST("histos_Casc/InvMassXiMinusTrue"), cascMC.ptMC(), casc.cascradius(), casc.mXi());
Expand All @@ -1334,7 +1334,7 @@
}
}
if (isCascadeSelected(casc, collision, cascMC.rapidityMC(2), kOmegaM)) {
histos.fill(HIST("histos_Casc/QA_CascCandidates"), 5.5);
histos.fill(HIST("histos_Casc/QA_CascadeCandidates"), 5.5);
if (checkCascadeMCAssociation(cascMC, kOmegaM)) {
histos.fill(HIST("histos_Casc/QA_CascadeCandidates"), 6.5);
histos.fill(HIST("histos_Casc/InvMassOmegaMinusTrue"), cascMC.ptMC(), casc.cascradius(), casc.mOmega());
Expand All @@ -1354,7 +1354,7 @@
////////// Collision QA - MC //////////
///////////////////////////////////////

void processGenerated(soa::Join<aod::McCollisions, aod::MultsExtraMC>::iterator const& mcCollision, aod::McParticles const& mcParticles, soa::SmallGroups<o2::soa::Join<o2::aod::Collisions, o2::aod::McCollisionLabels, o2::aod::EvSels, aod::PVMults>> const& collisions)
void processGenerated(soa::Join<aod::McCollisions, aod::MultsExtraMC>::iterator const& mcCollision, aod::McParticles const& mcParticles, soa::SmallGroups<o2::soa::Join<o2::aod::Collisions, o2::aod::McCollisionLabels, o2::aod::EvSels, aod::PVMults>> const& collisions, aod::BCsWithTimestamps const&)
{
// Apply selections on MC collisions
if (eventSelections.applyZVtxSelOnMCPV && std::abs(mcCollision.posZ()) > eventSelections.maxZVtxPosition) {
Expand Down
Loading