[Trigger] Update macro to upload zorro objects for 2026#15926
Merged
fgrosa merged 1 commit intoAliceO2Group:masterfrom Apr 22, 2026
Merged
[Trigger] Update macro to upload zorro objects for 2026#15926fgrosa merged 1 commit intoAliceO2Group:masterfrom
fgrosa merged 1 commit intoAliceO2Group:masterfrom
Conversation
fgrosa
requested review from
alibuild,
ariedel-cern,
lietava and
mpuccio
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 2 errors, |
vkucera
reviewed
Apr 22, 2026
| if (!hCounterTVX) { | ||
| std::cout << "No hCounterTVX histogram found in the file, skipping upload for run " << runString << std::endl; | ||
| continue; | ||
| hCounterTVX = static_cast<TH1*>(scalersFile->Get("eventselection-run3/luminosity/hCounterTVX")); |
Collaborator
There was a problem hiding this comment.
Never use static_cast to downcast pointers. It's not safe. Use dynamic_cast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.