Skip to content

[PWGLF] Move the dndeta analysis to LF tasks.#15988

Merged
abmodak merged 5 commits intoAliceO2Group:masterfrom
hyungjun-lee:dndeta_update
Apr 28, 2026
Merged

[PWGLF] Move the dndeta analysis to LF tasks.#15988
abmodak merged 5 commits intoAliceO2Group:masterfrom
hyungjun-lee:dndeta_update

Conversation

@hyungjun-lee
Copy link
Copy Markdown
Contributor

Add dndetaHi.cxx implementing the DndetaHi DPL task that measures charged-particle pseudorapidity density in pp and Pb-Pb collisions. Register the new workflow in CMakeLists.txt.

Key features:

  • Five process functions: EventStat, MCCounting, Counting, Gen, V0Counting
  • Event classification: INEL, INEL>0, DD/SD/ND (via HepMC process ID)
  • Centrality via FT0M (pp) or FT0C (Pb-Pb)
  • MC particle ID (π/K/p) and strange-mother tagging
  • pT extrapolation systematic variations (up/down weights)
  • V0 topological selection for K0s, Λ, Λ̄

I have reset the Git repository by deleting the previous log and initialized it anew. I have completed all the code revisions suggested by vit and would appreciate it if you could verify the changes.

Add dndetaHi.cxx implementing the DndetaHi DPL task that measures
charged-particle pseudorapidity density in pp and Pb-Pb collisions.
Register the new workflow in CMakeLists.txt.

Key features:
- Five process functions: EventStat, MCCounting, Counting, Gen, V0Counting
- Event classification: INEL, INEL>0, DD/SD/ND (via HepMC process ID)
- Centrality via FT0M (pp) or FT0C (Pb-Pb)
- MC particle ID (π/K/p) and strange-mother tagging
- pT extrapolation systematic variations (up/down weights)
- V0 topological selection for K0s, Λ, Λ̄

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

O2 linter results: ❌ 1 errors, ⚠️ 2 warnings, 🔕 0 disabled

hyungjun-lee and others added 2 commits April 28, 2026 12:17
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b2b7f91 at 2026-04-28 05:24:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:224:50: error: arithmetic between enumeration type 'PtVariation' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:224:66: error: arithmetic between enumeration type 'PtVariation' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:225:49: error: arithmetic between enumeration type 'EventCategory' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:225:63: error: arithmetic between enumeration type 'EventCategory' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:226:52: error: arithmetic between enumeration type 'TriggerClass' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:226:67: error: arithmetic between enumeration type 'TriggerClass' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:227:55: error: arithmetic between enumeration type 'ParticleType' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:227:70: error: arithmetic between enumeration type 'ParticleType' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:228:50: error: arithmetic between enumeration type 'Species' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:228:65: error: arithmetic between enumeration type 'Species' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:230:47: error: arithmetic between enumeration type 'TrackSign' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:230:62: error: arithmetic between enumeration type 'TrackSign' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:231:47: error: arithmetic between enumeration type 'AnalysisStep' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/GlobalEventProperties/dndetaHi.cxx:231:62: error: arithmetic between enumeration type 'AnalysisStep' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

hyungjun-lee and others added 2 commits April 28, 2026 13:25
- Cast enum values to int in AxisSpec declarations to fix
  -Werror=deprecated-enum-float-conversion build errors (GCC 14)
- Add missing registry.fill(SelInelSel8Mcz10) in processMCCounting

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 28, 2026

Why are you duplicating #15779 ?

@hyungjun-lee
Copy link
Copy Markdown
Contributor Author

Why are you duplicating #15779 ?

Dear @vkucera , As I am not yet accustomed to the pull request process, I deleted my local repository due to a command line tools update and subsequently closed my previous pull request to open a new one. If this approach causes any issues, I will investigate how to restore the previous pull request instead.

@abmodak abmodak merged commit c90fe0f into AliceO2Group:master Apr 28, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants