[Common,PWGDQ,PWGJE,PWGLF] Preslice requires table type rather than iterator type#16258
Open
aalkin wants to merge 1 commit into
Open
[Common,PWGDQ,PWGJE,PWGLF] Preslice requires table type rather than iterator type#16258aalkin wants to merge 1 commit into
aalkin wants to merge 1 commit into
Conversation
aalkin
requested review from
a team,
HorstMa,
alibuild,
ddobrigk,
dsekihat,
ercolessi,
fjonasALICE,
fmazzasc,
iarsene,
jgrosseo,
ktf,
lhusova,
lucamicheletti93,
maciacco,
maoyx,
mcoquet642,
mfasDa,
mhemmer-cern,
mpuccio,
nzardosh,
omvazque,
raymondEhlers,
romainschotter and
skundu692
as code owners
|
O2 linter results: ❌ 284 errors, |
github-actions
Bot
changed the title
romainschotter
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preslicedeclaration is designed to take table type, previously this code worked by accident and will no longer work with the upcoming changes. The changed lines, anyway, look like typos, where thesfrom table types was simply missed. This change can be merged directly, as it does not change the actual behavior of the tasks.@dsekihat could you please merge this directly? It would take too much time to wait for individual approvals and the change does not require any extra validation other than the CI.