[PWGHF] Cut variation: add QA histograms, save output upon user's request#16297
Merged
Conversation
Contributor
lubynets
commented
May 18, 2026
lubynets
commented
- Added
$\chi^2$ histogram; - Added histogram with minimzation status, showing whether fit was (1) successful, (2) vector monotony violation took place or (3) fit failed according to the definition introduced by PR #12055;
- Added possibility to configure via json file, which output histograms to save. Default settings are conservative - to save everything;
- Checked the efficiency vector for monotony. In case of fail, exit with fatal error (since in contrary to raw yield or residual vector which can be non-monotnous due to numerical artifacts, the efficiency vector is supposed to be monotonous by construction)
lubynets
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
zhangbiao-phy
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.