[Common] Remove workaround for trigger bc shift#16489
Merged
Merged
Conversation
ekryshen
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
dsekihat
approved these changes
Jun 1, 2026
vkucera
reviewed
Jun 1, 2026
| // FIXME ideally cursors could be readable | ||
| // to avoid duplicate memory allocation but ok | ||
| struct bcselEntry { | ||
| struct bcselEntry { // o2-linter: disable=name/struct (temporary fix) |
Collaborator
There was a problem hiding this comment.
Why did you disable this error instead of fixing it?
Also, what does "temporary fix" mean?
vkucera
reviewed
Jun 1, 2026
|
|
||
| // bc selection configurables | ||
| struct bcselConfigurables : o2::framework::ConfigurableGroup { | ||
| struct bcselConfigurables : o2::framework::ConfigurableGroup { // o2-linter: disable=name/struct (temporary fix) |
vkucera
reviewed
Jun 1, 2026
|
|
||
| // event selection configurables | ||
| struct evselConfigurables : o2::framework::ConfigurableGroup { | ||
| struct evselConfigurables : o2::framework::ConfigurableGroup { // o2-linter: disable=name/struct (temporary fix) |
vkucera
reviewed
Jun 1, 2026
|
|
||
| // luminosity configurables | ||
| struct lumiConfigurables : o2::framework::ConfigurableGroup { | ||
| struct lumiConfigurables : o2::framework::ConfigurableGroup { // o2-linter: disable=name/struct (temporary fix) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger bc shift was needed for early pp2022 passes (<=apass3). Not used any longer.
See also #16396