[PWGUD] Add new task upcVmRof.cxx#16497
Draft
jgcn wants to merge 5 commits into
Draft
Conversation
Collaborator
|
@jgcn Your branch is five months old. Please update it and make sure that the PR passes the checks before you mark it as ready for review. |
Please consider the following formatting changes to AliceO2Group#16497
|
O2 linter results: ❌ 14 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for 137a216 at 2026-06-02 15:46: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 137a216 at 2026-06-02 15:49: Full log here. |
vkucera
requested changes
Jun 2, 2026
Comment on lines
+23
to
+39
| #include "CCDB/BasicCCDBManager.h" | ||
| #include "CCDB/CcdbApi.h" | ||
| #include "CommonConstants/LHCConstants.h" | ||
| #include "CommonDataFormat/BunchFilling.h" | ||
| #include "DataFormatsFDD/Digit.h" | ||
| #include "DataFormatsFIT/Triggers.h" | ||
| #include "DataFormatsParameters/AggregatedRunInfo.h" | ||
| #include "DataFormatsParameters/GRPLHCIFData.h" | ||
| #include "DataFormatsParameters/GRPMagField.h" | ||
| #include "DataFormatsParameters/GRPObject.h" | ||
| #include "Framework/ASoA.h" | ||
| #include "Framework/ASoAHelpers.h" | ||
| #include "Framework/AnalysisDataModel.h" | ||
| #include "Framework/AnalysisTask.h" | ||
| #include "Framework/HistogramRegistry.h" | ||
| #include "Framework/runDataProcessing.h" | ||
| #include "ReconstructionDataFormats/Vertex.h" |
Collaborator
There was a problem hiding this comment.
External headers must be included with <>. Also make sure that you include exactly what you use.
Comment on lines
+162
to
+168
| // histograms | ||
| HistogramRegistry bcTH1Registry{"bcTH1Registry", {}}; | ||
| std::map<std::string, std::shared_ptr<TH1>> bcTH1Pointers; | ||
| HistogramRegistry bcTH2Registry{"bcTH2Registry", {}}; | ||
| std::map<std::string, std::shared_ptr<TH2>> bcTH2Pointers; | ||
| HistogramRegistry colTH1Registry{"colTH1Registry", {}}; | ||
| std::map<std::string, std::shared_ptr<TH1>> colTH1Pointers; |
Collaborator
There was a problem hiding this comment.
Why do you declare multiple registries?
Comment on lines
+178
to
+179
| static const int kRofPerOrbit = 6; // valid for pO, OO and PbPb in Run 3 | ||
| static const int kRofShift = 64; // bc shift of ITS. Valid for pO, OO and PbPb in Run 3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task to study 2 and 4 track vector meson photonuclear production taking into account the ROF and the Time Frame of the candidate.