Skip to content

[PWGCF] Fix MC only processing in femto producer#16888

Merged
ariedel-cern merged 1 commit into
AliceO2Group:masterfrom
ariedel-cern:master
Jul 1, 2026
Merged

[PWGCF] Fix MC only processing in femto producer#16888
ariedel-cern merged 1 commit into
AliceO2Group:masterfrom
ariedel-cern:master

Conversation

@ariedel-cern

@ariedel-cern ariedel-cern commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Fix MC only processing process function in the femto producer task.

@github-actions github-actions Bot added the pwgcf label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@ariedel-cern ariedel-cern marked this pull request as ready for review July 1, 2026 09:39
@ariedel-cern ariedel-cern enabled auto-merge (squash) July 1, 2026 09:39

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern ariedel-cern disabled auto-merge July 1, 2026 12:37
@ariedel-cern ariedel-cern enabled auto-merge (squash) July 1, 2026 12:37

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@vkucera

vkucera commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@ariedel-cern Please fix the title.

@ariedel-cern ariedel-cern changed the title [PWGCF] Fix MC only processing [PWGCF] Fix MC only processing in femto producer Jul 1, 2026
@alibuild

alibuild commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5b81563 at 2026-07-01 21:04:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ grep -E '^/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/.+: error: ' /sw/BUILD/28c47b41aa1489b8ac813a3967eec5e55819513b/O2Physics-code-check/error-log.txt
++ sed -e s,/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/,,g
++ sort -V
++ uniq
++ grep -E '^/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/.+: warning: ' /sw/BUILD/28c47b41aa1489b8ac813a3967eec5e55819513b/O2Physics-code-check/error-log.txt
++ sed -e s,/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/,,g
++ sort -V
++ uniq
++ true
+++ wc -l
++ N_ERROR=7
+++ wc -l
++ N_WARNING=0
++ echo 'Found 7 errors and 0 warnings.'
Found 7 errors and 0 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/28c47b41aa1489b8ac813a3967eec5e55819513b/O2Physics-code-check/errors.txt
PWGCF/Femto/Core/mcBuilder.h:19:10: error: 'PWGCF/Femto/Core/dataTypes.h' file not found [clang-diagnostic-error]
PWGCF/Femto/Core/mcBuilder.h:37:11: error: variable 'o2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/Femto/TableProducer/femtoProducer.cxx:16:10: error: 'PWGCF/Femto/Core/cascadeBuilder.h' file not found [clang-diagnostic-error]
PWGCF/Femto/TableProducer/femtoProducer.cxx:52:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
PWGCF/Femto/TableProducer/femtoProducer.cxx:85:8: error: constructor does not initialize these fields: confCcdb, collisionBuilderProducts, confCollisionTables, confCollisionFilters, confCollisionBits, confCollisionRctFlags, collisionBuilder, trackBuilderProducts, confTrackTables, trackBuilder, confTrackBits, confTrackFilters, v0builderProducts, confV0Tables, confV0Filters, confK0shortBits, k0shortBuilder, confLambdaBits, lambdaBuilder, antilambdaBuilder, cascadeBuilderProducts, confCascadeTables, confCascadeFilters, confXiBits, xiBuilder, confOmegaBits, omegaBuilder, kinkBuilderProducts, confKinkTables, confKinkFilters, confSigmaBits, sigmaBuilder, confSigmaPlusBits, sigmaPlusBuilder, confMc, confMcTables, mcProducts, mcBuilder, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/Femto/TableProducer/femtoProducer.cxx:215:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/Femto/TableProducer/femtoProducer.cxx:229:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@ariedel-cern ariedel-cern merged commit 8ce975b into AliceO2Group:master Jul 1, 2026
20 of 22 checks passed
@vkucera

vkucera commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@ariedel-cern You merged the PR with the original title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants