Skip to content

[PWGCF] add weight calculation from weight histogram and subsampling#16901

Draft
pykuan wants to merge 3 commits into
AliceO2Group:masterfrom
pykuan:master
Draft

[PWGCF] add weight calculation from weight histogram and subsampling#16901
pykuan wants to merge 3 commits into
AliceO2Group:masterfrom
pykuan:master

Conversation

@pykuan

@pykuan pykuan commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 2, 2026
@github-actions github-actions Bot changed the title add weight calculation from weight histogram and subsampling [PWGCF] add weight calculation from weight histogram and subsampling Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2d61bf0 at 2026-07-02 14:20:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 94 errors and 4 warnings.'
Found 94 errors and 4 warnings.
++ [[ 94 -gt 0 ]]
++ cat /sw/BUILD/ede590ed0dc5c2a282e5e5898e1a2afc69145da8/O2Physics-code-check/errors.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:97:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:97:13: error: variable 'eventHistNames' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:111:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:111:13: error: variable 'particleHistNames' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:127:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:127:13: error: variable 'corrHistNames' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:139:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:139:13: error: variable 'centEstmNames' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:151:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:151:13: error: variable 'multEstmNames' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:162:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:162:13: error: variable 'cutBeforeAfterNames' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:168:8: error: constructor does not initialize these fields: ccdb, pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:234:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:285:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:290:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:296:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:301:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:308:10: error: no header providing "std::map" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:328:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:329:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:335:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:336:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:339:10: error: constructor does not initialize these fields: h1, h2, h3, h4, h5, h6, h7, h8 [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:346:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:347:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:501:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:507:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:570:14: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:580:14: error: variable 'objectIter' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:585:41: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:591:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:599:23: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:600:27: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:636:22: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:640:24: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:650:18: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:656:22: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:660:24: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:690:22: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:694:24: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:719:26: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@vkucera vkucera marked this pull request as draft July 2, 2026 13:39
@vkucera

vkucera commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

@pykuan Please fix your formatting before opening a PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants