Skip to content

PWG-UD: added tutorial examples#2350

Merged
pbuehler merged 6 commits intoAliceO2Group:masterfrom
pbuehler:master
Apr 19, 2023
Merged

PWG-UD: added tutorial examples#2350
pbuehler merged 6 commits intoAliceO2Group:masterfrom
pbuehler:master

Conversation

@pbuehler
Copy link
Copy Markdown
Collaborator

@pbuehler pbuehler commented Apr 7, 2023

. some updates DGPIDSelector
. adaptions of DGCandAnalyzer, diffQA, diffMCQA

@pbuehler pbuehler enabled auto-merge (squash) April 7, 2023 17:56
@pbuehler pbuehler disabled auto-merge April 12, 2023 05:32
@pbuehler pbuehler enabled auto-merge (squash) April 12, 2023 05:32
@pbuehler
Copy link
Copy Markdown
Collaborator Author

@mpuccio, @strogolo HI, I think you have to approve this because of some changes in selectBCRange.cxx. These are necessary to avoid compilation warnings.

mpuccio
mpuccio previously approved these changes Apr 12, 2023
@ddobrigk
Copy link
Copy Markdown
Collaborator

Hi @pbuehler, thanks a lot for the tutorial code! Note, however, that in last week's meeting, we have agreed to have the tasks under O2Physics/tutorials/PWGxx and not in the individual PWG directories. Could you please move the tasks there? Thanks a lot!

. some updates DGPIDSelector
. adaptions of DGCandAnalyzer, diffQA, diffMCQA
comparison of integer expressions of different signedness
@pbuehler
Copy link
Copy Markdown
Collaborator Author

Hi @pbuehler, thanks a lot for the tutorial code! Note, however, that in last week's meeting, we have agreed to have the tasks under O2Physics/tutorials/PWGxx and not in the individual PWG directories. Could you please move the tasks there? Thanks a lot!

@pbuehler pbuehler closed this Apr 13, 2023
auto-merge was automatically disabled April 13, 2023 14:34

Pull request was closed

@pbuehler pbuehler reopened this Apr 13, 2023
@pbuehler pbuehler enabled auto-merge (squash) April 13, 2023 14:35
@pbuehler
Copy link
Copy Markdown
Collaborator Author

Hi @ddobrigk, could you please approve this.

ddobrigk
ddobrigk previously approved these changes Apr 14, 2023
Copy link
Copy Markdown
Collaborator

@ddobrigk ddobrigk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pbuehler !

@pbuehler pbuehler disabled auto-merge April 14, 2023 08:42
@pbuehler pbuehler enabled auto-merge (squash) April 14, 2023 08:43
@pbuehler pbuehler self-assigned this Apr 14, 2023
@pbuehler
Copy link
Copy Markdown
Collaborator Author

Dear @mpuccio, I think this needs again your approval.

@pbuehler pbuehler disabled auto-merge April 18, 2023 11:29
@pbuehler pbuehler enabled auto-merge (squash) April 18, 2023 11:29
@ddobrigk ddobrigk disabled auto-merge April 18, 2023 13:55
@ddobrigk ddobrigk enabled auto-merge (squash) April 18, 2023 13:55
@ddobrigk
Copy link
Copy Markdown
Collaborator

ddobrigk commented Apr 18, 2023

Hi, I am unsure about why this wasn't merged yet. I see the approvers listed are @ktf @strogolo @jgrosseo and core... Maybe someone in this list can try?

@pbuehler pbuehler disabled auto-merge April 19, 2023 09:24
@pbuehler pbuehler enabled auto-merge (squash) April 19, 2023 09:24
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @pbuehler.

@pbuehler pbuehler merged commit dff8985 into AliceO2Group:master Apr 19, 2023
AlexBigO pushed a commit to AlexBigO/O2Physics that referenced this pull request Apr 21, 2023
* . added tutorial examples
. some updates DGPIDSelector
. adaptions of DGCandAnalyzer, diffQA, diffMCQA

* avoid compilation warning because of ...
comparison of integer expressions of different signedness

* avoid compilation warning

* moved UDTutorials to O2Physics/Tutorials/PWGUD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants