Skip to content

Remove dependencies from NucleiSpectraTask#2459

Merged
njacazio merged 6 commits intoAliceO2Group:masterfrom
mpuccio:master
Apr 24, 2023
Merged

Remove dependencies from NucleiSpectraTask#2459
njacazio merged 6 commits intoAliceO2Group:masterfrom
mpuccio:master

Conversation

@mpuccio
Copy link
Copy Markdown
Collaborator

@mpuccio mpuccio commented Apr 21, 2023

  • Remove dependency from the track propagation
  • Remove TOF pid full dependency
  • Final touches

njacazio
njacazio previously approved these changes Apr 21, 2023
Copy link
Copy Markdown
Collaborator

@njacazio njacazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mpuccio thanks! Indeed this is a use case that we should bring to the attention of the community and discuss at the WP4+14 so that we can improve how the tracking is done for all tasks, in any case it would be needed for long trains with multiple wagons

@njacazio njacazio enabled auto-merge (squash) April 21, 2023 16:34
@mpuccio
Copy link
Copy Markdown
Collaborator Author

mpuccio commented Apr 21, 2023

Yes, I think that when the development of the on-demand track cuts from @ddobrigk becomes available, such tricks could be avoided. But unfortunately, last time, we needed approval from the PB just because the track propagation was taking too long, and with these modifications we can avoid that in the future.

@ddobrigk
Copy link
Copy Markdown
Collaborator

Yes, I think that when the development of the on-demand track cuts from @ddobrigk becomes available, such tricks could be avoided. But unfortunately, last time, we needed approval from the PB just because the track propagation was taking too long, and with these modifications in the future, we can avoid that.

Fully agreed :-) now Anton fixed the bug that was holding me back, so I have to get back to that because it will make a good impact on CPU. I will have more time after the O2 tutorials and this is one of the things I want to finish! And for now, having this done in your task is great as it will allow us to save CPU immediately.

@njacazio
Copy link
Copy Markdown
Collaborator

njacazio commented Apr 21, 2023

sure, let's make this point then! (we replied in the same time ;0)

@njacazio njacazio merged commit 6139b05 into AliceO2Group:master Apr 24, 2023
AlexBigO pushed a commit to AlexBigO/O2Physics that referenced this pull request May 11, 2023
* Remove dependency from the track propagation

* Remove TOF pid full dependency

* Final touches

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants