Skip to content

[EMCAL-888] caloLabelConverter: adjust to mask removal, emcalaCorrect…#2464

Merged
jgrosseo merged 1 commit intoAliceO2Group:masterfrom
mhemmer-cern:EMCAL-888
Apr 25, 2023
Merged

[EMCAL-888] caloLabelConverter: adjust to mask removal, emcalaCorrect…#2464
jgrosseo merged 1 commit intoAliceO2Group:masterfrom
mhemmer-cern:EMCAL-888

Conversation

@mhemmer-cern
Copy link
Copy Markdown
Collaborator

…ionTask: Add MCProcess function

  • Adjust the caloLabelConvert to the removal of the mask column in the McCaloLabel table

  • Add a process function for MC in the emcalCorrectionTask. Currently just as a starting position for further changes to adopt a full MC process function

…ionTask: Add MCProcess function

- Adjust the caloLabelConvert to the removal of the mask column in the McCaloLabel table

- Add a process function for MC in the emcalCorrectionTask. Currently just as a starting position for further changes to adopt a full MC process function
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c63c944 at 2023-04-22 11:36:

## sw/BUILD/O2Physics-latest/log
/sw/slc7_x86-64/O2/nightly-20230419-local1/include/Framework/AnalysisHelpers.h:46:33: error: static assertion failed: Argument number mismatch
/sw/slc7_x86-64/O2/nightly-20230419-local1/include/Framework/AnalysisHelpers.h:48:11: error: no match for call to '(o2::framework::{anonymous}::memfun_type<void (o2::framework::TableBuilder::persist<std::vector<int, std::allocator<int> >, short unsigned int, std::vector<float, std::allocator<float> > >(const std::array<const char*, 3>&)::<lambda(unsigned int, o2::framework::BuilderMaker<std::vector<int> >::FillType, o2::framework::BuilderMaker<short unsigned int>::FillType, o2::framework::BuilderMaker<std::vector<float> >::FillType)>::*)(unsigned int, std::vector<int>, short unsigned int, std::vector<float>) const>::type {aka std::function<void(unsigned int, std::vector<int>, short unsigned int, std::vector<float>)>}) (int, const std::vector<int>&, const std::vector<float>&)'
ninja: build stopped: subcommand failed.

Full log here.

@mhemmer-cern mhemmer-cern marked this pull request as draft April 22, 2023 09:39
@mhemmer-cern mhemmer-cern marked this pull request as ready for review April 22, 2023 09:40
@jgrosseo
Copy link
Copy Markdown
Contributor

@ktf @TimoWilken It seems again that the O2 alidist PR update was not merged. Is this still manual work and how it could be automatized?

The related PR is here (merged 3 days ago): AliceO2Group/AliceO2#11205 (comment)

@jgrosseo jgrosseo enabled auto-merge (squash) April 25, 2023 11:37
@jgrosseo
Copy link
Copy Markdown
Contributor

Needs PWGJE approval

@ktf
Copy link
Copy Markdown
Member

ktf commented Apr 25, 2023

Automating without unprotecting the branch was not doable a while ago when I checked. We should check again.

Copy link
Copy Markdown
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jgrosseo jgrosseo merged commit 428e01d into AliceO2Group:master Apr 25, 2023
AlexBigO pushed a commit to AlexBigO/O2Physics that referenced this pull request May 11, 2023
…ionTask: Add MCProcess function (AliceO2Group#2464)

- Adjust the caloLabelConvert to the removal of the mask column in the McCaloLabel table

- Add a process function for MC in the emcalCorrectionTask. Currently just as a starting position for further changes to adopt a full MC process function
adriansev pushed a commit to adriansev/O2Physics that referenced this pull request Jun 19, 2023
…ionTask: Add MCProcess function (AliceO2Group#2464)

- Adjust the caloLabelConvert to the removal of the mask column in the McCaloLabel table

- Add a process function for MC in the emcalCorrectionTask. Currently just as a starting position for further changes to adopt a full MC process function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants