Skip to content

instructions and scripts#2469

Merged
iarsene merged 8 commits intoAliceO2Group:masterfrom
mwinn2:master
Apr 26, 2023
Merged

instructions and scripts#2469
iarsene merged 8 commits intoAliceO2Group:masterfrom
mwinn2:master

Conversation

@mwinn2
Copy link
Copy Markdown
Contributor

@mwinn2 mwinn2 commented Apr 23, 2023

Contains a set of scripts and json configuration files to be used for the hands-on tutorials

iarsene
iarsene previously approved these changes Apr 26, 2023
@iarsene
Copy link
Copy Markdown
Collaborator

iarsene commented Apr 26, 2023

@ktf, @TimoWilken
Hi, I don't understand why the clang-format fails. I rerun the test with debugging enabled but I don't seem to get an obvious error. Moreover, @mwinn2 run clang on his commits and there was no change. Can you please have a look? These are needed for the tutorial sessions.

@TimoWilken
Copy link
Copy Markdown
Contributor

Hi @iarsene, where do the Tutorials/PWGDQ/readerConfiguration_*.json files come from?

We have clang-format configured to format JSON files with 4-space indents, to match what O2 produces, and the above files have 2-space indents.

As always with the clang-format check, it creates a PR in the PR author's fork, in this case here: mwinn2#1. @mwinn2 can merge this PR to fix the clang-format errors.

Please consider the following formatting changes to AliceO2Group#2469
@iarsene iarsene enabled auto-merge (squash) April 26, 2023 13:48
@iarsene
Copy link
Copy Markdown
Collaborator

iarsene commented Apr 26, 2023

Hi @iarsene, where do the Tutorials/PWGDQ/readerConfiguration_*.json files come from?

We have clang-format configured to format JSON files with 4-space indents, to match what O2 produces, and the above files have 2-space indents.

As always with the clang-format check, it creates a PR in the PR author's fork, in this case here: mwinn2#1. @mwinn2 can merge this PR to fix the clang-format errors.

Hi Timo, the json files are taken from a private repository which we use in PWG-DQ. I have no enabled checks on the PRs from that repo unfortunately. I will check if I can enable them so that for the future we don't run into similar problems.

@iarsene iarsene merged commit 8297e46 into AliceO2Group:master Apr 26, 2023
AlexBigO pushed a commit to AlexBigO/O2Physics that referenced this pull request May 11, 2023
* instructions and scripts

* presentation

* remove supporting material

* removed spaces

* remove white spaces

* adding lines at the end

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
adriansev pushed a commit to adriansev/O2Physics that referenced this pull request Jun 19, 2023
* instructions and scripts

* presentation

* remove supporting material

* removed spaces

* remove white spaces

* adding lines at the end

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants