PWGCF: bug fixes in femtodream#2735
Merged
Merged
Conversation
For the o2-aod-merger to work on merging derived data generated by the femtodream-producer task the naming of table have to follow the naming conventions of the O2 framework.
ariedel-cern
requested review from
alibuild,
jgrosseo,
lauraser,
mpuccio,
saganatt,
strogolo,
victor-gonzalez and
zchochul
as code owners
| static constexpr std::string_view MCTypeName[kNMCTypes] = {"", "_MC"}; | ||
|
|
||
| DECLARE_SOA_INDEX_COLUMN(FemtoDreamCollision, femtoDreamCollision); | ||
| // DECLARE_SOA_INDEX_COLUMN(FemtoDreamCollision, femtoDreamCollision); |
Collaborator
There was a problem hiding this comment.
Please, not commented code. Much less in the datamodel
Collaborator
There was a problem hiding this comment.
I took the freedom to remove the commented line
| using FemtoDreamMCLabel = FemtoDreamMCLabels::iterator; | ||
| DECLARE_SOA_TABLE(FDMCLabels, "AOD", "FDMCLabel", //! Table joinable to FemtoDreamParticle containing the MC labels | ||
| mcfdlabel::FDMCParticleId); | ||
| // using FDMCLabel = FDMCLabels::iterator; |
Collaborator
There was a problem hiding this comment.
Please, not commented code
Collaborator
There was a problem hiding this comment.
I took the freedom to remove the commented line
Removed data model commented code
victor-gonzalez
approved these changes
Jun 2, 2023
lauraser
approved these changes
Jun 2, 2023
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Jul 11, 2023
* Feat: add |eta| cut to V0s * Feat: add automatice systematic variations to cutculator * Fix: fix debug tasks * Fix: fix naming of femtodream tables For the o2-aod-merger to work on merging derived data generated by the femtodream-producer task the naming of table have to follow the naming conventions of the O2 framework. * Fix: fix order of includes * Fix: fix copyright headers * Revert "Fix: fix copyright headers" This reverts commit 09a0db6. * Fix: fix copyright headers * Fix: use consistent headers * Update FemtoDerived.h Removed data model commented code --------- Co-authored-by: Anton Riedel <anton.riedel@tum.de> Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 7, 2023
* Feat: add |eta| cut to V0s * Feat: add automatice systematic variations to cutculator * Fix: fix debug tasks * Fix: fix naming of femtodream tables For the o2-aod-merger to work on merging derived data generated by the femtodream-producer task the naming of table have to follow the naming conventions of the O2 framework. * Fix: fix order of includes * Fix: fix copyright headers * Revert "Fix: fix copyright headers" This reverts commit 09a0db6. * Fix: fix copyright headers * Fix: use consistent headers * Update FemtoDerived.h Removed data model commented code --------- Co-authored-by: Anton Riedel <anton.riedel@tum.de> Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
chengtt0406
pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
* Feat: add |eta| cut to V0s * Feat: add automatice systematic variations to cutculator * Fix: fix debug tasks * Fix: fix naming of femtodream tables For the o2-aod-merger to work on merging derived data generated by the femtodream-producer task the naming of table have to follow the naming conventions of the O2 framework. * Fix: fix order of includes * Fix: fix copyright headers * Revert "Fix: fix copyright headers" This reverts commit 09a0db6. * Fix: fix copyright headers * Fix: use consistent headers * Update FemtoDerived.h Removed data model commented code --------- Co-authored-by: Anton Riedel <anton.riedel@tum.de> Co-authored-by: Victor Gonzalez <victor.gonzalez.sebastian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several bug fixes of the FemtoDream framework: