Skip to content

[PWGJE Validation] Include track check for leading tracks in jetTrackCollisionQa and fix overcounting of jets in mcJetTrackCollisionQa #2750

Merged
nzardosh merged 2 commits into
AliceO2Group:masterfrom
jloemker:master
Jun 5, 2023
Merged

[PWGJE Validation] Include track check for leading tracks in jetTrackCollisionQa and fix overcounting of jets in mcJetTrackCollisionQa #2750
nzardosh merged 2 commits into
AliceO2Group:masterfrom
jloemker:master

Conversation

@jloemker
Copy link
Copy Markdown
Contributor

@jloemker jloemker commented Jun 5, 2023

Hey @fkrizek and @GijsvWeelden,

Many thanks for your comments on the jetvalidation task ! I included the following changes.

For the jetTrackCollisionQa (Filip):

  • all abs() are changed to fabs()
  • the trackSelection check applies now also for the potential leading track
    -> This fixes the number of leading tracks.

For the mcJetTrackCollisionQa (Gijs):

  • the loop over detector and particle level jets are now in the .has_mcCollision() loop
  • the 'fillMcTrackHistos' function got the collision as additional argument to do a track to collision association
  • the jets themselves are now also associated with the collisionId/mcCollisionId
    -> This fixes the over-counting of jets.

Cheers,
Johanna

jloemker added 2 commits June 5, 2023 01:47
…e trackSelection for leading tracks and change abs to fabs in jetTrackCollisionQa
@nzardosh nzardosh merged commit 9092656 into AliceO2Group:master Jun 5, 2023
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Jul 11, 2023
…CollisionQa and fix overcounting of jets in mcJetTrackCollisionQa (AliceO2Group#2750)

* Fix MC jet bug via collision association and add track filter; Include trackSelection for leading tracks and change abs to fabs in jetTrackCollisionQa

* clang formatting for PR
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 7, 2023
…CollisionQa and fix overcounting of jets in mcJetTrackCollisionQa (AliceO2Group#2750)

* Fix MC jet bug via collision association and add track filter; Include trackSelection for leading tracks and change abs to fabs in jetTrackCollisionQa

* clang formatting for PR
chengtt0406 pushed a commit to chengtt0406/O2Physics that referenced this pull request Dec 6, 2023
…CollisionQa and fix overcounting of jets in mcJetTrackCollisionQa (AliceO2Group#2750)

* Fix MC jet bug via collision association and add track filter; Include trackSelection for leading tracks and change abs to fabs in jetTrackCollisionQa

* clang formatting for PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants