[PWGJE Validation] Include track check for leading tracks in jetTrackCollisionQa and fix overcounting of jets in mcJetTrackCollisionQa #2750
Merged
Conversation
…e trackSelection for leading tracks and change abs to fabs in jetTrackCollisionQa
nzardosh
approved these changes
Jun 5, 2023
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Jul 11, 2023
…CollisionQa and fix overcounting of jets in mcJetTrackCollisionQa (AliceO2Group#2750) * Fix MC jet bug via collision association and add track filter; Include trackSelection for leading tracks and change abs to fabs in jetTrackCollisionQa * clang formatting for PR
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 7, 2023
…CollisionQa and fix overcounting of jets in mcJetTrackCollisionQa (AliceO2Group#2750) * Fix MC jet bug via collision association and add track filter; Include trackSelection for leading tracks and change abs to fabs in jetTrackCollisionQa * clang formatting for PR
chengtt0406
pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
…CollisionQa and fix overcounting of jets in mcJetTrackCollisionQa (AliceO2Group#2750) * Fix MC jet bug via collision association and add track filter; Include trackSelection for leading tracks and change abs to fabs in jetTrackCollisionQa * clang formatting for PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @fkrizek and @GijsvWeelden,
Many thanks for your comments on the jetvalidation task ! I included the following changes.
For the jetTrackCollisionQa (Filip):
-> This fixes the number of leading tracks.
For the mcJetTrackCollisionQa (Gijs):
-> This fixes the over-counting of jets.
Cheers,
Johanna