Skip to content

Conversation

@scattaru
Copy link
Contributor

Dear all,

  • I've fixed the evaluation of associated particle efficiency requiring to use only particles coming from sel8 events for the reconstructed part (numerator).
  • I've fixed the secondary particle contamination evaluation requiring that the Ds meson used to build the correlations is a real signal candidate.

Let me know if there are any comments,
Best regards,
Samuele

@scattaru
Copy link
Contributor Author

Dear all,
Following what it was reported by @fgrosa in the HF O2 Analysis channel on the usage of sel8 in the processes which use MC samples not anchored I think that inserting the selection as I did the process will not work anymore. So I can add a configurable to choose if I want to apply the sel8 or not which seems to me the fast way at the moment or I can also remove that part. For the moment I would convert this PR in a draft.

Best regards,
Samuele

@scattaru scattaru marked this pull request as draft April 11, 2024 16:29
@scattaru scattaru marked this pull request as ready for review April 15, 2024 07:55
@scattaru scattaru requested a review from hahassan7 as a code owner April 15, 2024 07:55
@scattaru
Copy link
Contributor Author

Dear all,
the PR is ready for the review now. I have added a configurable (i.e. useSel8) in order to have the possibility to choose to select or not the collision requiring the sel8 selection. And I have done some little modifications in order to adapt the code for the evaluation of the systematic uncertainties of the analysis. Let me know for any comment.

Best regards,
Samuele

Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scattaru thanks a lot!
In principle it would be better to templetize the function in order to avoid the consumption of the EvSel table if the event selection is not applied (see for instance

/// Event selection with trigger selection
void processTrigSel(soa::Join<aod::Collisions, aod::EvSels>::iterator const& collision)
{
selectCollision<true, CentralityEstimator::None>(collision);
}
PROCESS_SWITCH(HfTrackIndexSkimCreatorTagSelCollisions, processTrigSel, "Use trigger selection", false);
/// Event selection without trigger selection
void processNoTrigSel(aod::Collision const& collision)
{
selectCollision<false, CentralityEstimator::None>(collision);
}
). However, since this is needed for the SQM preliminaries I approve it (but consider the comment above for the future, thanks!).

@fgrosa fgrosa merged commit ba1e278 into AliceO2Group:master Apr 15, 2024
@scattaru
Copy link
Contributor Author

Hi @fgrosa,
Thanks a lot for the suggestion, in future I'll rewrite that part of the code following the way it is done in the TrackIndexSkimCreator

Thanks,
Samuele

@scattaru scattaru deleted the TrackSelection branch April 16, 2024 11:13
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
…ncy evaluation (AliceO2Group#5577)

* Minor adjustments in assoc particle efficiency evaluation

* Changing the code for evaluating systematics on candidate selection
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
…ncy evaluation (AliceO2Group#5577)

* Minor adjustments in assoc particle efficiency evaluation

* Changing the code for evaluating systematics on candidate selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants