modifing randomness mechanism in a pair rel. momentum calculation #5618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glromane
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
victor-gonzalez
approved these changes
Apr 15, 2024
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Nice!
I wonder if, as you peak the time since epoch, a pattern in the execution time would not as well bias the pair ordering
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @victor-gonzalez ,
In this commit we're trying to improve the randomness mechanism for a pair assignment. In case of 3d we're sensitive to the projections of the relative momentum (in 1d we take an abs. value -- irrelevant). In principle pairs must be the same but the pair order [particle1, particle2] must be random. The pairing has a pattern and in order to eliminate it we used shuffling before, this time we just randomly choose the sign of the momenta difference p1 - p2 I.e. order. We expect it to be a more correct way of eliminating any patterns. Could you please approve this commit? Thank you.
Sincerely yours, Gleb.