Skip to content

[DPG] Update k0s: add occupancy selection#6252

Merged
njacazio merged 2 commits into
AliceO2Group:masterfrom
njacazio:nj-k0s
May 23, 2024
Merged

[DPG] Update k0s: add occupancy selection#6252
njacazio merged 2 commits into
AliceO2Group:masterfrom
njacazio:nj-k0s

Conversation

@njacazio
Copy link
Copy Markdown
Collaborator

@njacazio njacazio commented May 23, 2024

No description provided.

@njacazio njacazio enabled auto-merge (squash) May 23, 2024 09:59
@njacazio njacazio disabled auto-merge May 23, 2024 09:59
alibuild
alibuild approved these changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio enabled auto-merge (squash) May 23, 2024 09:59
alibuild
alibuild previously approved these changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented May 23, 2024

Error while checking build/O2Physics/o2 for e734daa at 2024-05-23 12:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6252-slc7_x86-64/0/DPG/Tasks/AOTTrack/V0Cascades/perfK0sResolution.cxx:98:106: error: narrowing conversion of '5.0e-1' from 'double' to 'int' [-Wnarrowing]
/sw/SOURCES/O2Physics/6252-slc7_x86-64/0/DPG/Tasks/AOTTrack/V0Cascades/perfK0sResolution.cxx:99:107: error: narrowing conversion of '-5.0e-1' from 'double' to 'int' [-Wnarrowing]
/sw/slc7_x86-64/O2/daily-20240523-0200-local1/include/Framework/StructToTuple.h:139:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/slc7_x86-64/GCC-Toolchain/v12.2.0-alice1-12/include/c++/12.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(perfK0sResolution*&)'
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio disabled auto-merge May 23, 2024 13:54
@njacazio njacazio enabled auto-merge (squash) May 23, 2024 13:55
alibuild
alibuild approved these changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit 641bda5 into AliceO2Group:master May 23, 2024
@njacazio njacazio deleted the nj-k0s branch May 23, 2024 13:55
mvolkl pushed a commit to mvolkl/O2Physics that referenced this pull request May 23, 2024
@njacazio
[DPG] Update k0s: add occupancy selection (AliceO2Group#6252)
42ae210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@iouribelikov iouribelikov Awaiting requested review from iouribelikov iouribelikov is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@njacazio @alibuild