PWGCF: JCorran: dedicated weights loader#6256
Merged
Merged
Conversation
jaelpark
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
|
|
||
| effWeight = 1.0f; //<--- todo | ||
|
|
||
| output(phiWeight, effWeight); |
Collaborator
There was a problem hiding this comment.
Be careful on how you will use this table
The tracks table has tracks that are not associated to collisions and that means they will not be in this output which in its turn means you will not be able to join this table to the tracks table
Collaborator
Author
There was a problem hiding this comment.
Thanks for the point, will be careful with this.
victor-gonzalez
approved these changes
May 23, 2024
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I approve it for the time being but check my comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.