Skip to content

ppphi trigger v1#6268

Merged
lauraser merged 6 commits into
AliceO2Group:masterfrom
echizzal:ppphitrigger
May 27, 2024
Merged

ppphi trigger v1#6268
lauraser merged 6 commits into
AliceO2Group:masterfrom
echizzal:ppphitrigger

Conversation

@echizzal
Copy link
Copy Markdown
Contributor

No description provided.

lauraser
lauraser previously approved these changes May 24, 2024
lauraser
lauraser previously approved these changes May 24, 2024
@lauraser lauraser enabled auto-merge (squash) May 24, 2024 12:35
@mpuccio
Copy link
Copy Markdown
Collaborator

mpuccio commented May 25, 2024

Hi @echizzal, thanks a lot for your development! Why don't you simply modify the CFFilter? In any case you won't break the current processing, and it is easier to understand what is the new part

auto-merge was automatically disabled May 26, 2024 17:22

Head branch was pushed to by a user without write access

@echizzal echizzal requested a review from lauraser May 27, 2024 05:26
mpuccio
mpuccio previously approved these changes May 27, 2024
@mpuccio mpuccio enabled auto-merge (squash) May 27, 2024 05:36
auto-merge was automatically disabled May 27, 2024 06:20

Head branch was pushed to by a user without write access

mpuccio
mpuccio previously approved these changes May 27, 2024
@mpuccio mpuccio enabled auto-merge (squash) May 27, 2024 06:34
lauraser
lauraser previously approved these changes May 27, 2024
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for eb5037b at 2024-05-27 09:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6268-slc7_x86-64/0/EventFiltering/PWGCF/CFFilterPPPhi.cxx:370:13: error: 'Nproton' was not declared in this scope; did you mean 'protons'?
/sw/SOURCES/O2Physics/6268-slc7_x86-64/0/EventFiltering/PWGCF/CFFilterPPPhi.cxx:393:13: error: 'Nantiproton' was not declared in this scope; did you mean 'antiprotons'?
/sw/SOURCES/O2Physics/6268-slc7_x86-64/0/EventFiltering/PWGCF/CFFilterPPPhi.cxx:479:13: error: 'Nphi' was not declared in this scope; did you mean 'phi'?
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled May 27, 2024 08:10

Head branch was pushed to by a user without write access

@echizzal echizzal dismissed stale reviews from lauraser and mpuccio via 8179831 May 27, 2024 08:10
@echizzal echizzal requested a review from lauraser May 27, 2024 08:39
@lauraser lauraser enabled auto-merge (squash) May 27, 2024 09:17
@lauraser lauraser merged commit dcffb8a into AliceO2Group:master May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants