[PWGDQ] Fixes in dqEfficiency_withassoc and adding muon refit in tableMakerMC#6815
Merged
lucamicheletti93 merged 12 commits intoJul 17, 2024
Merged
Conversation
Collaborator
mcoquet642
commented
Jul 10, 2024
- Adding checks in dqEfficiency to make sure considered particle has an associated mcparticle
- Adding refit option for global muons in tableMakerMC
- removing protection on global muon covariance in FillPairVertexing, this is fixed when using the option "UseAbsDCA" in the configuration of the DCAFitter
Collaborator
|
Error while checking build/O2Physics/o2 for 0800ecf at 2024-07-11 08:08: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for b94abda at 2024-07-11 17:20: Full log here. |
singiamtel
reviewed
Jul 11, 2024
Contributor
singiamtel
left a comment
There was a problem hiding this comment.
Small typo on the copy paste
Collaborator
|
Hi, its fine for me. But since it deals with muon data, I hope Luca can have a look and approve. If he is away, just ping me and I will approve. |
Collaborator
|
@mcoquet642 thanks for the fix, I approve the PR! |
lucamicheletti93
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.