Skip to content

[PWGDQ] Fixes in dqEfficiency_withassoc and adding muon refit in tableMakerMC#6815

Merged
lucamicheletti93 merged 12 commits into
AliceO2Group:masterfrom
mcoquet642:dq-dqeff-fixes
Jul 17, 2024
Merged

[PWGDQ] Fixes in dqEfficiency_withassoc and adding muon refit in tableMakerMC#6815
lucamicheletti93 merged 12 commits into
AliceO2Group:masterfrom
mcoquet642:dq-dqeff-fixes

Conversation

@mcoquet642
Copy link
Copy Markdown
Collaborator

  • Adding checks in dqEfficiency to make sure considered particle has an associated mcparticle
  • Adding refit option for global muons in tableMakerMC
  • removing protection on global muon covariance in FillPairVertexing, this is fixed when using the option "UseAbsDCA" in the configuration of the DCAFitter

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Jul 10, 2024

Error while checking build/O2Physics/o2 for 0800ecf at 2024-07-11 08:08:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6815-slc7_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:799:7: error: expected ';' before '}' token
/sw/SOURCES/O2Physics/6815-slc7_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:654:148: error: unused parameter 'mftTracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/6815-slc7_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:654:148: error: unused parameter 'mftTracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b94abda at 2024-07-11 17:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6815-slc7_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:654:148: error: unused parameter 'mftTracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/6815-slc7_x86-64/0/PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx:654:148: error: unused parameter 'mftTracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

Copy link
Copy Markdown
Contributor

@singiamtel singiamtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo on the copy paste

Comment thread PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx Outdated
Comment thread PWGDQ/TableProducer/tableMaker_withAssoc.cxx Outdated
Comment thread PWGDQ/TableProducer/tableMaker_withAssoc.cxx Outdated
Comment thread PWGDQ/TableProducer/tableMakerMC_withAssoc.cxx Outdated
mcoquet642 and others added 7 commits July 11, 2024 20:07
Co-authored-by: Sergio Garcia <47090312+singiamtel@users.noreply.github.com>
Co-authored-by: Sergio Garcia <47090312+singiamtel@users.noreply.github.com>
Co-authored-by: Sergio Garcia <47090312+singiamtel@users.noreply.github.com>
Co-authored-by: Sergio Garcia <47090312+singiamtel@users.noreply.github.com>
@iarsene
Copy link
Copy Markdown
Collaborator

iarsene commented Jul 16, 2024

Hi, its fine for me. But since it deals with muon data, I hope Luca can have a look and approve. If he is away, just ping me and I will approve.

@lucamicheletti93
Copy link
Copy Markdown
Collaborator

@mcoquet642 thanks for the fix, I approve the PR!

@lucamicheletti93 lucamicheletti93 enabled auto-merge (squash) July 17, 2024 07:08
@lucamicheletti93 lucamicheletti93 merged commit 4099de3 into AliceO2Group:master Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants