Skip to content

PWGEM:LMee: added new cuts and histogram for opening angle#8146

Merged
dsekihat merged 3 commits into
AliceO2Group:masterfrom
jjungIKF:master
Oct 26, 2024
Merged

PWGEM:LMee: added new cuts and histogram for opening angle#8146
dsekihat merged 3 commits into
AliceO2Group:masterfrom
jjungIKF:master

Conversation

@jjungIKF
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread PWGEM/Dilepton/Core/DielectronCut.h Outdated
float dca_t2_3d = dca3DinSigma(t2);
float dca_ee_3d = std::sqrt((dca_t1_3d * dca_t1_3d + dca_t2_3d * dca_t2_3d) / 2.);
float phiv = o2::aod::pwgem::dilepton::utils::pairutil::getPhivPair(t1.px(), t1.py(), t1.pz(), t2.px(), t2.py(), t2.pz(), t1.sign(), t2.sign(), bz);
float opAng = 0;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use pairutil::getOpeningAngle? This is in PairUtilities.h.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for pointing this out. I am sorry that I overlooked this.

Comment thread PWGEM/Dilepton/Core/Dilepton.h Outdated
float deta = v1.Eta() - v2.Eta();
float dphi = v1.Phi() - v2.Phi();
o2::math_utils::bringToPMPi(dphi);
float opAng = 0;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use pairutil::getOpeningAngle? This is in PairUtilities.h.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for pointing this out. I am sorry that I overlooked this.

Comment thread PWGEM/Dilepton/Core/DielectronCut.h Outdated
bool mApplydEtadPhi{false}; // flag to apply deta, dphi cut between 2 tracks
float mMinDeltaEta{0.f};
float mMinDeltaPhi{0.f};
float mMinDeltaEta{0.f}, mMaxDeltaEta{1e10f};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default value of mMinDeltaEta should be -1e+10f now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread PWGEM/Dilepton/Core/DielectronCut.h Outdated
float mMinDeltaEta{0.f};
float mMinDeltaPhi{0.f};
float mMinDeltaEta{0.f}, mMaxDeltaEta{1e10f};
float mMinDeltaPhi{0.f}, mMaxDeltaPhi{1e10f};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default value of mMinDeltaPhi should be -1e+10f now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Configurable<bool> cfg_apply_detadphi{"cfg_apply_detadphi", false, "flag to apply deta-dphi elliptic cut"};
Configurable<float> cfg_min_deta{"cfg_min_deta", 0.02, "min deta between 2 electrons (elliptic cut)"};
Configurable<float> cfg_min_dphi{"cfg_min_dphi", 0.02, "min dphi between 2 electrons (elliptic cut)"};
Configurable<float> cfg_min_deta{"cfg_min_deta", 0.02, "min deta between 2 electrons (also for elliptic cut)"};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep in mind that there is a boolean value "cfg_apply_detadphi" to enable deta-dphi cut.

Copy link
Copy Markdown
Contributor Author

@jjungIKF jjungIKF Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this? What should I do to account for this?
I thought I accounted for this by the if-else structure in DielectronCuts.h line 145.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry. I overlooked if-else.

@dsekihat
Copy link
Copy Markdown
Collaborator

dsekihat commented Oct 25, 2024

Opening angle is included in elliptic deta-dphi cut, isn't it?
The elliptic deta-dphi cut takes care of different separation power between eta and phi. The separation of opening angle along eta is better than that along phi in 2D plot (deta-dphi). In this context, your opening angle cut (omega) is included in the elliptic deta-dphi cut.

@jjungIKF
Copy link
Copy Markdown
Contributor Author

I agree that opening angle should be somewhat included in the deta-dphi cut. But to be honest, I am missing the experience or imagination to know how exactly in translates exactly. So I would like to compare both cuts. In principle you are right and the deta-dphi should be superior as it provides more control.

@dsekihat dsekihat self-requested a review October 25, 2024 16:57
@dsekihat dsekihat enabled auto-merge (squash) October 25, 2024 16:57
@dsekihat dsekihat merged commit 3ca1189 into AliceO2Group:master Oct 26, 2024
dsekihat added a commit to dsekihat/O2Physics that referenced this pull request Oct 28, 2024
dsekihat added a commit to dsekihat/O2Physics that referenced this pull request Oct 28, 2024
dsekihat added a commit to dsekihat/O2Physics that referenced this pull request Oct 28, 2024
dsekihat added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants