Skip to content

PWGCF: Added nogap method to FlowPtContainer#8175

Merged
victor-gonzalez merged 2 commits into
AliceO2Group:masterfrom
EmilGorm:master
Oct 29, 2024
Merged

PWGCF: Added nogap method to FlowPtContainer#8175
victor-gonzalez merged 2 commits into
AliceO2Group:masterfrom
EmilGorm:master

Conversation

@EmilGorm
Copy link
Copy Markdown
Contributor

No description provided.

@EmilGorm EmilGorm marked this pull request as ready for review October 28, 2024 09:38
@victor-gonzalez
Copy link
Copy Markdown
Collaborator

@EmilGorm many thanks for this!

Two main points from my side

  • please, prefix the PR title with PWGCF: (this is a small one but helps a lot)
  • nowadays there are already a few active users of the Generic framework. I guess all the modifications will be backwards compatible. But it would be good if you announce the changes in the CF towards o2 mattermost channel for everyone in CF to know and also asking for feedback when potential issues happen

@EmilGorm EmilGorm changed the title Added nogap method to FlowPtContainer PWGCF: Added nogap method to FlowPtContainer Oct 29, 2024
@EmilGorm
Copy link
Copy Markdown
Contributor Author

Hi @victor-gonzalez

Thanks for the review. I have modified the title now.
The code should be backward compatible, except for removing some of the constructors, which should be called through the initialize method instead.

The only problem is that I have been removed from all my mattermost channels (seems my contract length had not been updated, but I have fixed this now). Would you happen to have, or do you know who has, the ability to add me back?

@victor-gonzalez
Copy link
Copy Markdown
Collaborator

Hi @EmilGorm
I tried to add you to the CF towards o2 channel and got a message saying that you must be a member of the ALICE team
Try to join the ALICE team in mattermost and perhaps all the subscriptions will be back
I see you in the CF towards o2 channel but as offline

Copy link
Copy Markdown
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmilGorm I approve it but, please, make an announcement in the CF towards o2 channel about the potential impact on current users and the incorporated functionality
Thanks!

@victor-gonzalez victor-gonzalez merged commit 12f7a04 into AliceO2Group:master Oct 29, 2024
joachimckh pushed a commit to joachimckh/O2Physics that referenced this pull request Oct 31, 2024
Co-authored-by: Emil Gorm Nielsen <emilgormnielsen@cern-ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants