[Common]: add user-friendly interface for trackTuner configuration. #8190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I add a user-friendly interface to configure the
TrackTunerobject in theCommon/TableProducer/trackPropagation.cxxworkflow.Inspired by the PR #6311 , I'm now proposing to make the
struct TrackTunerto inherit fromo2::framework::ConfigurableGroup. In this way:Configurables data members can be defined for thestruct TrackTuner;Configurablesof the workflow in which the instance of theTrackTuneris declared. In particular, theTrackTunerconfigurations appear now in theConfigurablelist ofCommon/TableProducer/trackPropagation.cxxin atrackTunerblock, i.e.:With this PR I keep the possibility to configure the
TrackTunerviastd::string, to grant backwards compatibility. However, I think that at a certain point we can make this option obsolete, and in case one can consider deprecating this option already in this PR.What do you think?
I leave the PR in draft for the time being.
Tagging @phymanshu and @arossi81 for their knowledge (just a technical development, that does not touch at all the
TrackTunerworking principles).The same approach can be utilized wherever a custom
TrackTunerinstance is present.Hoping to tag all interested people: @njacazio , @mpuccio , @fmazzasc , @ivorobye , @lbariogl , @nepeivodaRS, @fcatalan92 @fgrosa @fcolamar