PWGCF: flow: add Run3ITSall7Layers option and a new run-by-run task#8201
Merged
Conversation
Luzhiyongg
requested review from
alibuild,
ariedel-cern,
lauraser,
otonvd,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
| // Add output histograms to the registry | ||
| std::vector<int> temp = cfgRunNumbers; | ||
| RunNumbers = temp; | ||
| for (auto& runNumber : RunNumbers) { |
Collaborator
There was a problem hiding this comment.
Have you tried
for (auto runNumber : cfgRunNumbers.value)
Comment on lines
+109
to
+110
| std::vector<int> temp = cfgRunNumbers; | ||
| RunNumbers = temp; |
Collaborator
There was a problem hiding this comment.
Have you tried
std::vector<int> RunNumbers = cfgRunNumbers.value;
victor-gonzalez
approved these changes
Oct 29, 2024
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I would suggest to have a look at my comments for the next iteration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi reviewers,
The
FlowTask.cxxI am using has already consume a lot of memory (>500 MB per wagon). So I'd like to create to new task to hold the run-by-run output. This task would be lightweight for each run.