PWGCF: Add PDG code selections for the MC particle correlations #8226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… efficiency species ID.
jaelpark
requested review from
alibuild,
ariedel-cern,
jgrosseo,
lauraser,
otonvd,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
Comment on lines
741
to
+748
| case 2212: // proton | ||
| case -2212: | ||
| return 2; | ||
| default: | ||
| case 421: // D0 | ||
| case -421: | ||
| return 3; | ||
| default: | ||
| return 4; |
Collaborator
There was a problem hiding this comment.
I would suggest using named constants from TPDGCode.h extended by Common/Constants/include/CommonConstants/PhysicsConstants.h if needed
Collaborator
Author
There was a problem hiding this comment.
Yes, this is something we should probably change eventually.
victor-gonzalez
approved these changes
Oct 29, 2024
Contributor
|
This looks good to me. I let you see with Victor's comment. |
joachimckh
pushed a commit
to joachimckh/O2Physics
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.