[PWGDQ] Implemented ConfigurableGroup for tableMaker_withAssoc, warning fixes and explanatory comments #8531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 19, 2024 09:54
Added explanatory comments and fixed some compilation warnings
Squashed commit of the following:
commit 09423c87e03580830bf43652c669d1e188a308f4
Author: Ionut Cristian Arsene <iarsene@cern.ch>
Date: Mon Nov 18 13:10:04 2024 +0100
Additional optimization and comments on code
commit 697ae69f4b8d01200b41fbf439e37d2a9c3a9d97
Author: Ionut Cristian Arsene <iarsene@cern.ch>
Date: Sun Nov 17 13:31:18 2024 +0100
Made an enum for the ordering of the statistics histogram list
commit bb057cdf3ca4a21c9305bed6f0ca29ba1bd4bcf3
Author: Ionut Cristian Arsene <iarsene@cern.ch>
Date: Sun Nov 17 13:08:06 2024 +0100
implemented ConfigurableGroup in tableMaker_withAssoc
iarsene
requested review from
alibuild,
dsekihat,
feisenhu and
lucamicheletti93
as code owners
lucamicheletti93
approved these changes
Nov 19, 2024
joachimckh
pushed a commit
to joachimckh/O2Physics
that referenced
this pull request
Dec 2, 2024
…ng fixes and explanatory comments (AliceO2Group#8531) Co-authored-by: Ionut Cristian Arsene <iarsene@cern.ch>
joachimckh
pushed a commit
to joachimckh/O2Physics
that referenced
this pull request
Dec 2, 2024
…ng fixes and explanatory comments (AliceO2Group#8531) Co-authored-by: Ionut Cristian Arsene <iarsene@cern.ch>
wefeng1110
pushed a commit
to wefeng1110/O2Physics
that referenced
this pull request
Dec 6, 2024
…ng fixes and explanatory comments (AliceO2Group#8531) Co-authored-by: Ionut Cristian Arsene <iarsene@cern.ch>
Archita-Dash
pushed a commit
to Archita-Dash/O2Physics
that referenced
this pull request
Dec 11, 2024
…ng fixes and explanatory comments (AliceO2Group#8531) Co-authored-by: Ionut Cristian Arsene <iarsene@cern.ch>
hernasab
pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Dec 20, 2024
…ng fixes and explanatory comments (AliceO2Group#8531) Co-authored-by: Ionut Cristian Arsene <iarsene@cern.ch>
feisenhu
pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Jan 8, 2025
…ng fixes and explanatory comments (AliceO2Group#8531) Co-authored-by: Ionut Cristian Arsene <iarsene@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.