[PWGCF] support for EP angle and few more event cuts #8904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abilandz
requested review from
alibuild,
ariedel-cern,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
| ec.fdEventCuts[eImpactParameter][eMin] = lImpactParameter[eMin]; | ||
| ec.fdEventCuts[eImpactParameter][eMax] = lImpactParameter[eMax]; | ||
|
|
||
| auto lEventPlaneAngle = (vector<float>)cf_ec.cfEventPlaneAngle; |
Collaborator
There was a problem hiding this comment.
Use instead std::vector<float> The linter will be happier
Comment on lines
5661
to
+5662
| // !eh.fEventHistograms[eImpactParameter][eSim][ba] ? true : eh.fEventHistograms[eImpactParameter][eSim][ba]->Fill(collision.impactParameter()); // yes, because in this branch 'collision' is always aod::McCollision | ||
| // !eh.fEventHistograms[eEventPlaneAngle][eSim][ba] ? true : eh.fEventHistograms[eEventPlaneAngle][eSim][ba]->Fill(collision.eventPlaneAngle()); // yes, because in this branch 'collision' is always aod::McCollision |
Collaborator
There was a problem hiding this comment.
Remember not leaving code commented
Contributor
Author
There was a problem hiding this comment.
It's only temporarily commented out, I will use this code eventually, after I resolve and validate a few other thingies related to it.
Comment on lines
5693
to
+5694
| // !eh.fEventHistograms[eImpactParameter][eSim][ba] ? true : eh.fEventHistograms[eImpactParameter][eSim][ba]->Fill(collision.impactParameter()); // yes, because in this branch 'collision' is always aod::McCollision | ||
| // !eh.fEventHistograms[eEventPlaneAngle][eSim][ba] ? true : eh.fEventHistograms[eEventPlaneAngle][eSim][ba]->Fill(collision.eventPlaneAngle()); // yes, because in this branch 'collision' is always aod::McCollision |
| } else if (ec.fsEventCuts[eReferenceMultiplicityEstimator].EqualTo("multNTracksPV", TString::kIgnoreCase)) { | ||
| ebye.fReferenceMultiplicity = collision.multNTracksPV(); | ||
| } else if (ec.fsEventCuts[eReferenceMultiplicityEstimator].EqualTo("multNTracksGlobal", TString::kIgnoreCase)) { | ||
| // ebye.fReferenceMultiplicity = collision.multNTracksGlobal(); // TBI 20241209 not validated yet |
| qa.fReferenceMultiplicity[eMultFT0C] = collision.multFT0C(); | ||
| qa.fReferenceMultiplicity[eMultFT0M] = collision.multFT0M(); | ||
| qa.fReferenceMultiplicity[eMultNTracksPV] = collision.multNTracksPV(); | ||
| // qa.fReferenceMultiplicity[eMultNTracksGlobal] = collision.multNTracksGlobal(); // TBI 20241209 not validated yet |
| using CollisionRecSim = soa::Join<aod::Collisions, aod::McCollisionLabels, EventSelection>::iterator; | ||
| // using CollisionRecSim = soa::Join<aod::Collisions, aod::McCollisionLabels, aod::MultsExtraMC, EventSelection>::iterator; | ||
| // using CollisionRecSim = soa::Join<aod::Collisions, aod::McCollisionLabels, aod::MultsExtraMC, EventSelection>::iterator; | ||
| // using CollisionRecSim = soa::Join<aod::Collisions, aod::McCollisionLabels, aod::MultsExtraMC, EventSelection>::iterator; // TBI 20241210 validating "MultsExtraMC" for multMCNParticlesEta08 |
| // using CollisionRecSim = soa::Join<aod::Collisions, aod::McCollisionLabels, aod::MultsExtraMC, EventSelection>::iterator; // TBI 20241210 validating "MultsExtraMC" for multMCNParticlesEta08 | ||
| using CollisionSim = aod::McCollision; | ||
| using TracksRec = soa::Join<aod::Tracks, aod::TracksExtra, aod::TracksDCA, aod::TrackSelection>; | ||
| // using TrackRec = soa::Join<aod::Tracks, aod::TracksExtra, aod::TracksDCA, aod::TrackSelection>::iterator; |
victor-gonzalez
approved these changes
Dec 10, 2024
Archita-Dash
pushed a commit
to Archita-Dash/O2Physics
that referenced
this pull request
Dec 11, 2024
hernasab
pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Dec 20, 2024
feisenhu
pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Jan 8, 2025
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.