[PWGJE] Implementation of Hadronic Correction task #9084

Archita-Dash · 2024-12-20T14:19:14Z

Hadronic Correction in the EMCAL framework is implemented to avoid the double counting of the charged particles' contribution in jets.

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

nzardosh · 2024-12-20T14:34:25Z

Hi Archita, thanks for the PR. Just to understand, this would mean that for jet finding the corrected cluster energy would be used instead of the standard cluster energy? otherwise it is all the same?

Archita-Dash · 2024-12-20T14:54:44Z

Hi Nima. yes, that's right. The jet finder needs to use the corrected energy values (we have 4 corrected energy columns- depends on what the analyser wants). everything else remains the same.

Archita-Dash · 2024-12-20T16:05:04Z

BTW Nima, I think the more efficient way to achieve this would be somehow to set up 4 different jet-finders for each corrected energy value such that the user can use whichever jet finder they want corresponding to the desired corrected energy.

nzardosh · 2024-12-20T16:33:28Z

BTW Nima, I think the more efficient way to achieve this would be somehow to set up 4 different jet-finders for each corrected energy value such that the user can use whichever jet finder they want corresponding to the desired corrected energy.

This would be good if the user needs to run all 4 jet finders at the same time for some reason. If they would instead each only be needed independently then i would make it a configurable in the jet finder to select which is used but only have it happen once. Let me know which is best

nzardosh · 2024-12-20T16:35:25Z

PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx

+using namespace o2::framework;
+using namespace o2::framework::expressions;
+using collisionEvSelIt = o2::soa::Join<o2::aod::Collisions, o2::aod::EvSels>::iterator;
+using selectedClusters = o2::soa::Filtered<o2::aod::EMCALClusters>;


one thing i would recommend here is not performing this on filtered clusters, otherwise this table would not be joinable with the original cluster table, unless exactly the same filters are used everywhere.

Archita-Dash · 2024-12-20T17:13:00Z

BTW Nima, I think the more efficient way to achieve this would be somehow to set up 4 different jet-finders for each corrected energy value such that the user can use whichever jet finder they want corresponding to the desired corrected energy.

This would be good if the user needs to run all 4 jet finders at the same time for some reason. If they would instead each only be needed independently then i would make it a configurable in the jet finder to select which is used but only have it happen once. Let me know which is best

Okay, you are right. Since each would be needed independently by the user, it makes more sense to define a configurable in the jet finder instead.

fjonasALICE · 2024-12-20T17:19:50Z

PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx

+        //  c) If you want to do systematic studies -> perform the above two checks a) and b), and then subtract 70% energy instead of 100%
+
+        // Perform dEta/dPhi matching
+        double dEta = match.track_as<myTracks>().eta() - cluster.eta();


this should use eta on the emcal surface instead of eta at vertex

fjonasALICE · 2024-12-20T17:20:12Z

PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx

+
+        // Perform dEta/dPhi matching
+        double dEta = match.track_as<myTracks>().eta() - cluster.eta();
+        double dPhi = TVector2::Phi_mpi_pi(match.track_as<myTracks>().phi() - cluster.phi());


likewise this should use phi propagated to emcal surface and not at vertex

fjonasALICE · 2024-12-20T17:22:35Z

PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx

+          auto trackPhiLow = -funcPtDepPhi.Eval(mom);
+
+          if ((dPhi < trackPhiHigh && dPhi > trackPhiLow) && fabs(dEta) < trackEtaMax) {
+            if (Nmatches == 0) {


while the list is indeed sorted to contain the closest track first, for safety reasons I would explicitly check that it is the closest of the ones you looped over

How would you think it go resorted? Because if she's doing a subselection of the already matched tracks if at all (which are in order of distance to the cluster). Skipping those which don't match her criteria should in principle not change the order.

It is not a big point. I just meant that if the list would be unsorted, the Nmatches number would be wrong

fjonasALICE · 2024-12-20T17:24:53Z

PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx

+          EclusterAll1 = subtractClusterEnergy(EclusterAll1, totalTrkP, fHadCorralltrks1, Nmatches, UseFraction1);
+        }
+
+        if (UseM02SubtractionScheme2) {


what is the M02 subtraction scheme and what is the difference bewteen one and two?

fjonasALICE · 2024-12-20T17:25:32Z

PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx

+      registry.fill(HIST("h2_ClsEvsEclusterAll2"), cluster.energy(), EclusterAll2);
+
+      // Fill the table with all four corrected energies
+      hadroniccorrectedclusters(Ecluster1, Ecluster2, EclusterAll1, EclusterAll2);


how does one match this table to the cluster table? What is the index? collision id?

but why would you want to have the collision ID or index accessed here? the main motive is to correct the cluster energies and then join them with the original cluster table. so as long as I am not looping over filtered clusters/selected clusters, I think they should be joinable.

they should become not joinable if you apply cuts here that do not get applied to the other table. This is why I suggested to remove all cuts in the hadronic correction task and apply cuts later (e.g. in full jet finder)

fjonasALICE · 2024-12-20T17:27:50Z

PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx

+    registry.add("h_matchedtracks", "Total matched tracks; track status;entries", {HistType::kTH1F, {{1, 0.5, 1.5}}});
+  }
+
+  Filter clusterDefinitionSelection = (o2::aod::emcalcluster::definition == mClusterDefinition) && (o2::aod::emcalcluster::time >= minTime) && (o2::aod::emcalcluster::time <= maxTime) && (o2::aod::emcalcluster::m02 > minM02) && (o2::aod::emcalcluster::m02 < maxM02);


Why are we doing any cluster cuts here? I think then the resulting table will no longer be joinable to the existing cluster table. I think this task should simply provide the values for all clusters. Cluster selection should then be done in the full jet finder

These I have defined for the cluster filter but in the main process function, I am now looping over all the EMCAL clusters and only only the selectedclusters. So, no cuts are applied anymore in this case on the clusters.

fjonasALICE · 2024-12-20T17:42:08Z

PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx

+    // For M02 in the single photon region, the signal is primarily: Single photons, single electrons, single MIPs
+    if (m02 > 0.1 && m02 < 0.4) {   //circular clusters(electron/photon)
+      Ecorr = Ecluster;  // Single electron, single MIP
+    } else if (m02 > 0.4) {


Normally (I think) if M02 is bigger than 0.4 and the number of matches is >1, there should be nothing subtracted. Could you explain why you changed the logic from the function we had in Run2?

well if this comment is made after comparing the present version of the code with that of the existing one in Run 2 then one also needs to recall that in Run 2 the M02 correction scheme was never correctly implemented or atleast not most likely used in analyses for the same reason I guess. Because if the value is 0.4 and then it could also be an electron in this case where if you don't subtract any energy, your correction is incorrect. That's why this has been taken care of here. But how this needs to be implemented for heavy-flavour jet analyses is something needs to be discussed and followed up later on.

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

alibuild · 2024-12-23T15:10:07Z

Error while checking build/O2Physics/o2 for e83d9c9 at 2024-12-23 16:10:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9084-slc9_x86-64/0/PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx:196:50: error: 'struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<2994056566>, o2::aod::Hash<2753472878>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4121608173>, o2::aod::Hash<3306343464>, o2::aod::Hash<2286545062> >, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3324719623>, o2::soa::Table<o2::aod::Hash<599863064>, o2::aod::Hash<2944948204>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3243953376>, o2::aod::Hash<3324719623>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<1274903626>, o2::soa::Table<o2::aod::Hash<184273500>, o2::aod::Hash<1996537442>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<518516411>, o2::aod::Hash<1274903626>, o2::aod::Hash<1926198916> > > >, o2::soa::Table<o2::aod::Hash<2486124941>, o2::aod::Hash<2977027599>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<2994056566>, o2::aod::Hash<2753472878>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4121608173>, o2::aod::Hash<3306343464>, o2::aod::Hash<2286545062> >, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3324719623>, o2::soa::Table<o2::aod::Hash<599863064>, o2::aod::Hash<2944948204>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3243953376>, o2::aod::Hash<3324719623>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<1274903626>, o2::soa::Table<o2::aod::Hash<184273500>, o2::aod::Hash<1996537442>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<518516411>, o2::aod::Hash<1274903626>, o2::aod::Hash<1926198916> > > >, o2::soa::Table<o2::aod::Hash<2486124941>, o2::aod::Hash<2977027599>, o2::aod::Hash<2286545062> > > >, o2::soa::Table<o2::aod::Hash<2994056566>, o2::aod::Hash<2753472878>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4121608173>, o2::aod::Hash<3306343464>, o2::aod::Hash<2286545062> >, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3324719623>, o2::soa::Table<o2::aod::Hash<599863064>, o2::aod::Hash<2944948204>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3243953376>, o2::aod::Hash<3324719623>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<1274903626>, o2::soa::Table<o2::aod::Hash<184273500>, o2::aod::Hash<1996537442>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<518516411>, o2::aod::Hash<1274903626>, o2::aod::Hash<1926198916> > > >, o2::soa::Table<o2::aod::Hash<2486124941>, o2::aod::Hash<2977027599>, o2::aod::Hash<2286545062> > >' has no member named 'etaEmcal'
/sw/SOURCES/O2Physics/9084-slc9_x86-64/0/PWGJE/TableProducer/emcalClusterHadronicCorrectionTask.cxx:197:71: error: 'struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<2994056566>, o2::aod::Hash<2753472878>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4121608173>, o2::aod::Hash<3306343464>, o2::aod::Hash<2286545062> >, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3324719623>, o2::soa::Table<o2::aod::Hash<599863064>, o2::aod::Hash<2944948204>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3243953376>, o2::aod::Hash<3324719623>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<1274903626>, o2::soa::Table<o2::aod::Hash<184273500>, o2::aod::Hash<1996537442>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<518516411>, o2::aod::Hash<1274903626>, o2::aod::Hash<1926198916> > > >, o2::soa::Table<o2::aod::Hash<2486124941>, o2::aod::Hash<2977027599>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<2994056566>, o2::aod::Hash<2753472878>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4121608173>, o2::aod::Hash<3306343464>, o2::aod::Hash<2286545062> >, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3324719623>, o2::soa::Table<o2::aod::Hash<599863064>, o2::aod::Hash<2944948204>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3243953376>, o2::aod::Hash<3324719623>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<1274903626>, o2::soa::Table<o2::aod::Hash<184273500>, o2::aod::Hash<1996537442>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<518516411>, o2::aod::Hash<1274903626>, o2::aod::Hash<1926198916> > > >, o2::soa::Table<o2::aod::Hash<2486124941>, o2::aod::Hash<2977027599>, o2::aod::Hash<2286545062> > > >, o2::soa::Table<o2::aod::Hash<2994056566>, o2::aod::Hash<2753472878>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4121608173>, o2::aod::Hash<3306343464>, o2::aod::Hash<2286545062> >, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3324719623>, o2::soa::Table<o2::aod::Hash<599863064>, o2::aod::Hash<2944948204>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3243953376>, o2::aod::Hash<3324719623>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<1274903626>, o2::soa::Table<o2::aod::Hash<184273500>, o2::aod::Hash<1996537442>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<518516411>, o2::aod::Hash<1274903626>, o2::aod::Hash<1926198916> > > >, o2::soa::Table<o2::aod::Hash<2486124941>, o2::aod::Hash<2977027599>, o2::aod::Hash<2286545062> > >' has no member named 'phiEmcal'
ninja: build stopped: subcommand failed.

Full log here.

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

…the PV

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

fjonasALICE · 2025-01-16T19:08:08Z

HI @Archita-Dash, just checking in with the status of this PR. Are you still working on the suggested changes or fighting with the mega linter and o2 linter? Can we help?

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

Archita-Dash · 2025-01-21T16:54:06Z

Hi @fjonasALICE . Your suggested changes have been taken care of. Kindly ignore the above repeatedly triggered o2-linter and mega-linter stuffs. This was because I was making some remote changes to my task and constantly updated the master branch and since this PR was still open, it kept on triggering these checks every time.

HI @nzardosh . I would need some help here. I wanted to create another PR to push some changes to my exisitng fuljet analysis task; however yesterday when I did so, unknowingly I kind of pushed those changes in this PR as I made them from the same branch itself. Could this be accepted here? I simply added event selection to reject MB events and added some more QA histos for the JJ MC checks. If this PR gets approved then it would be fairly easily for me to go ahead with the JJ MC QA checks.

nzardosh · 2025-01-22T09:05:23Z

Hi @Archita-Dash for me its fine but i am adding a central cut on the event weight soon so you will then need to convert your task to use that

Archita-Dash · 2025-01-22T09:21:53Z

Hi @Archita-Dash for me its fine but i am adding a central cut on the event weight soon so you will then need to convert your task to use that

Thank you, Nima!

Archita-Dash · 2025-01-23T16:05:04Z

@fjonasALICE this now only awaits your approval. Once done, I should be able to go ahead with JJ MC checks with more statistics on hyperloop.

… better

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

Archita-Dash requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern and nzardosh as code owners December 20, 2024 14:19

github-actions bot added pwgje datamodel labels Dec 20, 2024

github-actions bot changed the title ~~Implementation of Hadronic Correction task~~ [PWGJE] Implementation of Hadronic Correction task Dec 20, 2024

alibuild mentioned this pull request Dec 20, 2024

[PWGJE] Please consider the following formatting changes to #9084 Archita-Dash/O2Physics#11

Merged

Archita-Dash added a commit to Archita-Dash/O2Physics that referenced this pull request Dec 20, 2024

Merge pull request #11 from alibuild/alibot-cleanup-9084

ca56ed6

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

nzardosh reviewed Dec 20, 2024

View reviewed changes

Archita-Dash force-pushed the master branch from ca56ed6 to f3cdfa8 Compare December 20, 2024 17:38

fjonasALICE requested changes Dec 20, 2024

View reviewed changes

alibuild mentioned this pull request Dec 20, 2024

[PWGJE] Please consider the following formatting changes to #9084 Archita-Dash/O2Physics#12

Merged

fjonasALICE reviewed Dec 20, 2024

View reviewed changes

Archita-Dash added a commit to Archita-Dash/O2Physics that referenced this pull request Dec 20, 2024

Merge pull request #12 from alibuild/alibot-cleanup-9084

e582fa6

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

Archita-Dash force-pushed the master branch from 4c24236 to e83d9c9 Compare December 23, 2024 14:47

alibuild mentioned this pull request Dec 23, 2024

[PWGJE] Please consider the following formatting changes to #9084 Archita-Dash/O2Physics#13

Merged

Archita-Dash force-pushed the master branch from e83d9c9 to 8adc211 Compare December 23, 2024 15:11

Archita-Dash added a commit to Archita-Dash/O2Physics that referenced this pull request Dec 23, 2024

Merge pull request #13 from alibuild/alibot-cleanup-9084

5713f91

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

Archita-Dash added 3 commits December 24, 2024 14:29

implementing hadronic correction

785d3d8

removing filtered clusters and instead using all the EMCAL clusters

987c0af

removing filtered clusters and instead using all the EMCAL clusters

9355963

Archita-Dash added 2 commits December 24, 2024 14:29

obtaining track eta and phi info from the Emcal surface and not from …

565be19

…the PV

Merge branch 'master' of https://github.com/AliceO2Group/O2Physics

ec36dfa

Archita-Dash force-pushed the master branch from f6b725b to ec36dfa Compare January 6, 2025 11:28

Please consider the following formatting changes

25236bd

alibuild mentioned this pull request Jan 6, 2025

[PWGJE] Please consider the following formatting changes to #9084 Archita-Dash/O2Physics#14

Merged

Merge pull request #14 from alibuild/alibot-cleanup-9084

555d923

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

Archita-Dash and others added 3 commits January 20, 2025 19:08

Merge branch 'AliceO2Group:master' into master

7a0b6dc

adding QA histos for MC checks

3872876

Please consider the following formatting changes

71af7a0

alibuild mentioned this pull request Jan 20, 2025

[PWGJE] Please consider the following formatting changes to #9084 Archita-Dash/O2Physics#15

Merged

Archita-Dash and others added 3 commits January 21, 2025 17:27

Merge pull request #15 from alibuild/alibot-cleanup-9084

83b62c4

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

Merge branch 'AliceO2Group:master' into master

f486659

removed timing and M02 cuts on cluster definitions

7979ef9

nzardosh self-requested a review January 22, 2025 09:05

nzardosh previously approved these changes Jan 22, 2025

View reviewed changes

setting clusterE to 0 for circular clusters assuming tracking reso is…

de7e4db

… better

Archita-Dash dismissed nzardosh’s stale review via de7e4db January 24, 2025 14:01

Please consider the following formatting changes

cb9eadd

alibuild mentioned this pull request Jan 24, 2025

[PWGJE] Please consider the following formatting changes to #9084 Archita-Dash/O2Physics#16

Merged

Archita-Dash added 2 commits January 24, 2025 15:02

Merge branch 'AliceO2Group:master' into master

fd468ed

Merge pull request #16 from alibuild/alibot-cleanup-9084

f284c59

[PWGJE] Please consider the following formatting changes to AliceO2Group#9084

alibuild mentioned this pull request Jan 24, 2025

[PWGJE] Please consider the following formatting changes to #9084 Archita-Dash/O2Physics#17

Closed

fjonasALICE approved these changes Jan 24, 2025

View reviewed changes

fjonasALICE merged commit 2b8976b into AliceO2Group:master Jan 24, 2025
10 of 12 checks passed

smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025

[PWGJE] Implementation of Hadronic Correction task (AliceO2Group#9084)

37b0d64

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

[PWGJE] Implementation of Hadronic Correction task #9084

[PWGJE] Implementation of Hadronic Correction task #9084

Uh oh!

Conversation

Archita-Dash commented Dec 20, 2024

Uh oh!

nzardosh commented Dec 20, 2024

Uh oh!

Archita-Dash commented Dec 20, 2024

Uh oh!

Archita-Dash commented Dec 20, 2024

Uh oh!

nzardosh commented Dec 20, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Archita-Dash commented Dec 20, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alibuild commented Dec 23, 2024

Uh oh!

fjonasALICE commented Jan 16, 2025

Uh oh!

Archita-Dash commented Jan 21, 2025

Uh oh!

nzardosh commented Jan 22, 2025

Uh oh!

Archita-Dash commented Jan 22, 2025

Uh oh!

Archita-Dash commented Jan 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants