Skip to content

[PWGCF] Added corrections + only load new calibration histis per run #9451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktf merged 7 commits into from
Jan 22, 2025
Merged

[PWGCF] Added corrections + only load new calibration histis per run #9451

ktf merged 7 commits into from
Jan 22, 2025

Conversation

@cnkoster
Copy link
Contributor

@cnkoster cnkoster commented Jan 22, 2025

No description provided.

@github-actions github-actions bot added the pwgcf label Jan 22, 2025
@github-actions github-actions bot changed the title Added corrections + only load new calibration histis per run [PWGCF] Added corrections + only load new calibration histis per run Jan 22, 2025
@alibuild alibuild mentioned this pull request Jan 22, 2025
Merged
@cnkoster cnkoster marked this pull request as ready for review January 22, 2025 14:09
@alibuild
Copy link
Collaborator

alibuild commented Jan 22, 2025

Error while checking build/O2Physics/o2 for a076424 at 2025-01-22 15:22:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9451-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:167:12: error: unused variable 'fPtAxis' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/9451-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:364:32: error: comparison of integer expressions of different signedness: 'std::vector<TH1D*>::size_type' {aka 'long unsigned int'} and 'int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/9451-slc9_x86-64/0/PWGCF/Flow/Tasks/flowSP.cxx:371:32: error: comparison of integer expressions of different signedness: 'std::vector<GFWWeights*>::size_type' {aka 'long unsigned int'} and 'int' [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Jan 22, 2025
Merged
@cnkoster
Merge pull request #30 from alibuild/alibot-cleanup-9451
688b1a8 
[PWGCF] Please consider the following formatting changes to AliceO2Group#9451
@victor-gonzalez victor-gonzalez enabled auto-merge (squash) January 22, 2025 17:45
@ktf ktf disabled auto-merge January 22, 2025 21:25
@ktf
Copy link
Member

ktf commented Jan 22, 2025

Please fix the linter in a subsequent PR.

@ktf ktf merged commit 6d1b6d0 into AliceO2Group:master Jan 22, 2025
12 of 13 checks passed
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@cnkoster @alibuild @smaff92
[PWGCF] Added corrections + only load new calibration histis per run (A…
5883f37 
…liceO2Group#9451)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cnkoster @alibuild @ktf @victor-gonzalez