Skip to content

Conversation

@SwatiSaha-1997
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pwgcf label Jan 24, 2025
@github-actions github-actions bot changed the title ppCumRun2: Code for calculating efficiency and MC closure check [PWGCF] ppCumRun2: Code for calculating efficiency and MC closure check Jan 24, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for c5ba71b at 2025-01-24 14:13:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:413:9: error: 'trackSelected' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 53434f6 at 2025-01-24 15:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:153:28: error: 'myMCRecCollisions' does not name a type; did you mean 'MyMCRecCollisions'?
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:378:21: error: 'MyMCRecCollision' has not been declared
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:365:52: error: 'netProt' was not declared in this scope; did you mean 'net_prot'?
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:380:20: error: request for member 'has_mcCollision' in 'collision', which is of non-class type 'const int'
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:383:27: error: request for member 'centFT0M' in 'collision', which is of non-class type 'const int'
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:386:52: error: request for member 'posZ' in 'collision', which is of non-class type 'const int'
/sw/slc9_x86-64/O2/daily-20250124-0000-local2/include/Framework/AnalysisTask.h:544:53: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::inputsFromArgs(void (NetProtonCumulantsMC::*&)(const int&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3324719623>, o2::soa::Table<o2::aod::Hash<599863064>, o2::aod::Hash<2944948204>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3243953376>, o2::aod::Hash<3324719623>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<1274903626>, o2::soa::Table<o2::aod::Hash<184273500>, o2::aod::Hash<1996537442>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<518516411>, o2::aod::Hash<1274903626>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<3189221742>, o2::aod::Hash<2614466272>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2486124941>, o2::aod::Hash<2977027599>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2144302593>, o2::aod::Hash<3579936953>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2288810529>, o2::aod::Hash<1230184339>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1380449349>, o2::aod::Hash<1276726542>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2783244389>, o2::aod::Hash<3492532772>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4121608173>, o2::aod::Hash<3306343464>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<34190285>, o2::aod::Hash<1495290626>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2994056566>, o2::aod::Hash<2753472878>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1171693910>, o2::aod::Hash<942421572>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<263224968>, o2::aod::Hash<1586729726>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Table<o2::aod::Hash<412502005>, o2::aod::Hash<545027608>, o2::aod::Hash<2286545062> >&, const o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >&), const char*, bool&, std::vector<o2::framework::InputSpec>&, std::vector<ExpressionInfo>&, std::vector<std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > >&, std::vector<std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > >&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for bb1d9a2 at 2025-01-24 15:09:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:152:28: error: 'myMCRecCollisions' does not name a type; did you mean 'MyMCRecCollisions'?
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:377:21: error: 'MyMCRecCollision' has not been declared
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:364:52: error: 'netProt' was not declared in this scope; did you mean 'net_prot'?
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:379:20: error: request for member 'has_mcCollision' in 'collision', which is of non-class type 'const int'
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:382:27: error: request for member 'centFT0M' in 'collision', which is of non-class type 'const int'
/sw/SOURCES/O2Physics/9502-slc9_x86-64/0/PWGCF/EbyEFluctuations/Tasks/NetProtonCumulantsMC.cxx:385:52: error: request for member 'posZ' in 'collision', which is of non-class type 'const int'
/sw/slc9_x86-64/O2/daily-20250124-0000-local2/include/Framework/AnalysisTask.h:544:53: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::inputsFromArgs(void (NetProtonCumulantsMC::*&)(const int&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<3324719623>, o2::soa::Table<o2::aod::Hash<599863064>, o2::aod::Hash<2944948204>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3243953376>, o2::aod::Hash<3324719623>, o2::aod::Hash<1926198916> > >, o2::soa::JoinFull<o2::aod::Hash<1274903626>, o2::soa::Table<o2::aod::Hash<184273500>, o2::aod::Hash<1996537442>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<518516411>, o2::aod::Hash<1274903626>, o2::aod::Hash<1926198916> > >, o2::soa::Table<o2::aod::Hash<3189221742>, o2::aod::Hash<2614466272>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2486124941>, o2::aod::Hash<2977027599>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2144302593>, o2::aod::Hash<3579936953>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2288810529>, o2::aod::Hash<1230184339>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1380449349>, o2::aod::Hash<1276726542>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2783244389>, o2::aod::Hash<3492532772>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<4121608173>, o2::aod::Hash<3306343464>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<34190285>, o2::aod::Hash<1495290626>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2994056566>, o2::aod::Hash<2753472878>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<1171693910>, o2::aod::Hash<942421572>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<263224968>, o2::aod::Hash<1586729726>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Table<o2::aod::Hash<412502005>, o2::aod::Hash<545027608>, o2::aod::Hash<2286545062> >&, const o2::soa::JoinFull<o2::aod::Hash<3313470560>, o2::soa::Table<o2::aod::Hash<3827758336>, o2::aod::Hash<4186066504>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3988646457>, o2::aod::Hash<3313470560>, o2::aod::Hash<1926198916> > >&), const char*, bool&, std::vector<o2::framework::InputSpec>&, std::vector<ExpressionInfo>&, std::vector<std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > >&, std::vector<std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> > >&)'
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez
Copy link
Collaborator

Do you really want to use a new source file for your MC analysis?
In principle the detector level processing of the MC analysis must be identical as the processing on data. So you have to have two copies of the same code which is error prone and difficult to maintain/evolve. For the generator level processing of the MC analysis, it is usually smaller and can be easily handled as an additional process on the main source file without the need of replicating anything

@SwatiSaha-1997
Copy link
Contributor Author

Dear Victor, I will need a separate MC at this moment because I want to verify everything here, once verified the observable closure, I will merge the MC part in the Data code as you suggested. It will be very helpful if you could approve it for the time being. Many thanks in advance.
Best regards,
Swati

Copy link
Collaborator

@otonvd otonvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it on request of Swati. Please follow Victor's instructions to unify the code also for MC asap

@shouqiye shouqiye enabled auto-merge (squash) January 24, 2025 18:01
@shouqiye shouqiye merged commit a1fb42c into AliceO2Group:master Jan 24, 2025
13 of 14 checks passed
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants