Skip to content

[PWGCF] adjusted ft0 histos and added track selection #9618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
victor-gonzalez merged 1 commit into from
Jan 29, 2025
Merged

[PWGCF] adjusted ft0 histos and added track selection #9618

victor-gonzalez merged 1 commit into from
Jan 29, 2025

Conversation

@hernasab
Copy link
Contributor

@hernasab hernasab commented Jan 29, 2025

No description provided.

@github-actions github-actions bot added the pwgcf label Jan 29, 2025
@github-actions github-actions bot changed the title adjusted ft0 histos and added track selection [PWGCF] adjusted ft0 histos and added track selection Jan 29, 2025
@alibuild alibuild mentioned this pull request Jan 29, 2025
Closed
@hernasab hernasab closed this Jan 29, 2025
@hernasab hernasab reopened this Jan 29, 2025
@alibuild alibuild mentioned this pull request Jan 29, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented Jan 29, 2025

Error while checking build/O2Physics/o2 for 4f15dc2 at 2025-01-29 22:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9618-slc9_x86-64/0/PWGCF/Flow/Tasks/FlowZDCtask.cxx:246:9: error: unused variable 'multTrk' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Jan 29, 2025
Closed
@victor-gonzalez
Copy link
Collaborator

victor-gonzalez commented Jan 29, 2025

Please, rebase your changes to the latest version of O2Physics
Your fork/local repositories differ in 188 commits with the O2Physics master

@hernasab hernasab closed this Jan 29, 2025
@hernasab hernasab reopened this Jan 29, 2025
@hernasab
Copy link
Contributor Author

hernasab commented Jan 29, 2025

Please, rebase your changes to the latest version of O2Physics Your fork/local repositories differ in 188 commits with the O2Physics master

Ah I see the mistake now. thanks. should be fixed now.

victor-gonzalez
victor-gonzalez approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, follow linter recommendations in the next iteration

@victor-gonzalez victor-gonzalez enabled auto-merge (squash) January 29, 2025 22:47
@victor-gonzalez victor-gonzalez merged commit db858c5 into AliceO2Group:master Jan 29, 2025
19 of 22 checks passed
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
@hernasab @smaff92
[PWGCF] adjusted ft0 histos and added track selection (AliceO2Group#9618
7535b15 
)

Co-authored-by: Sabrina Hernandez <sabrina.gabrielle.hernandez@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hernasab @alibuild @victor-gonzalez