[PWGCF] FT0 amplitude and flow vs Nch

[ilikmeta]

No description provided.

[alibuild]

Error while checking build/O2Physics/o2 for 9bb9ae4 at 2025-01-30 04:52:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9620-slc9_x86-64/0/PWGCF/Flow/Tasks/FlowGFWPbPb.cxx:174:128: error: arithmetic between enumeration type 'FlowGFWPbPb::eventprogress' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

[alibuild]

Error while checking build/O2Physics/o2 for 9c9ca05 at 2025-01-30 07:32:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

[alibuild]

Error while checking build/O2Physics/o2 for a49e2d0 at 2025-01-30 07:49:

## sw/BUILD/O2Physics-latest/log
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):
CMake Error at cmake/O2PhysicsAddExecutable.cmake:113 (add_executable):

Full log here.

[ilikmeta]

Dear expert, from the first efford to push my taks, O2linter had few warnings regarding lower and upper case characters. So, I midified the name of the task from FlowGFWPbPb.cxx to flowGFWPbPb.cxx . Howevet when I do git status I still see the old name:

iris_antreas_likmeta@IrisAntreassMBP O2Physics % git status                                
On branch origin
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   PWGCF/Flow/Tasks/FlowGFWPbPb.cxx

Do you have any suggestion on how to resolve this? Thanks

[victor-gonzalez]

Dear expert, from the first efford to push my taks, O2linter had few warnings regarding lower and upper case characters. So, I midified the name of the task from FlowGFWPbPb.cxx to flowGFWPbPb.cxx . Howevet when I do git status I still see the old name:

iris_antreas_likmeta@IrisAntreassMBP O2Physics % git status                                
On branch origin
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   PWGCF/Flow/Tasks/FlowGFWPbPb.cxx

Do you have any suggestion on how to resolve this? Thanks

Not quite sure I understand your question
You refer to the name of the task but what you wrote is the name of the source file
In git, if you want to change the name of one of the files, it is recommended to use git mv because in that way the whole history is preserved. After that you have to commit the changes. All this at local repo level. Then you have to push your changes to your fork in gitHub and if you have an already open PR it will update automatically after that push

[victor-gonzalez]

The linter is suggesting you which name you should use according to the name of your workflow, flowGfwPbpb.cxx. Probably you can reconsider if you want PbPb in the name of either your workflow or your source code file. I guess, apart from configurations, nothing should prevent to run your task on pp or even in OO if available

[victor-gonzalez]

If you modify your source file according with the linter you should use the same name but with the first letter capitalized for your task name

[victor-gonzalez]

As suggested in the linter check Details link, you can run the checks locally before pushing your changes

[ilikmeta]

A new PR was produced from ilikmeta:master (by fault) and close this one.

[victor-gonzalez]

Please, don't close a PR that has been already commented
We have to start from zero has if nothing had passed before
That is a bit of waste of time

[ilikmeta]

My git was completely messed up and I pushed another PR through master. I closed that one as well. I tried to push again, but same thing, it went on master (I did not made a PR for this one) What is your suggestion to do?