[PWGCF] calculate v2 correction factor from MC #9742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luzhiyongg
requested review from
alibuild,
ariedel-cern,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
Collaborator
|
Error while checking build/O2Physics/o2 for 478916d at 2025-02-04 20:55: Full log here. |
Contributor
Author
|
@victor-gonzalez hi Victor, I've fixed the errors. Could you please review this pull request? |
| for (auto const& mcParticle : mcParticles) { | ||
| // focus on bulk: e, mu, pi, k, p | ||
| int pdgCode = std::abs(mcParticle.pdgCode()); | ||
| if (pdgCode != 11 && pdgCode != 13 && pdgCode != 211 && pdgCode != 321 && pdgCode != 2212) |
Collaborator
There was a problem hiding this comment.
Please, for the next iteration use named constants from TPDGCode.h instead of numbers
| float imp = mcCollision.impactParameter(); | ||
|
|
||
| int pdgCode = std::abs(mcParticle.pdgCode()); | ||
| if (pdgCode != 3312 && pdgCode != 3334) |
Comment on lines
+269
to
+278
| if (pdgCode == 3312) | ||
| histos.fill(HIST("hBVsPtVsPhiGeneratedXi"), imp, deltaPhi, mcParticle.pt()); | ||
| if (pdgCode == 3334) | ||
| histos.fill(HIST("hBVsPtVsPhiGeneratedOmega"), imp, deltaPhi, mcParticle.pt()); | ||
|
|
||
| if (cascades.size() > 0) { | ||
| if (pdgCode == 3312) | ||
| histos.fill(HIST("hBVsPtVsPhiGlobalXi"), imp, deltaPhi, mcParticle.pt()); | ||
| if (pdgCode == 3334) | ||
| histos.fill(HIST("hBVsPtVsPhiGlobalOmega"), imp, deltaPhi, mcParticle.pt()); |
victor-gonzalez
approved these changes
Feb 5, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my comments for the next iteration
nasirmehdimalik
pushed a commit
to nasirmehdimalik/O2Physics
that referenced
this pull request
Feb 12, 2025
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Feb 17, 2025
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.