MCH: fixed memory leak in custom mergeable histograms#1022
Merged
Barthelemy merged 1 commit intoJan 26, 2022
Merged
Conversation
Collaborator
|
Could you fix the format ? if we can review this morning it can be part of the next flp suite |
Contributor
Author
|
I am on that, but I have to do it manually as I am recompiling the O2 stack after an update... |
Contributor
Author
|
@Barthelemy clang fomatting check are now ok. I have still to commit the improvements for the automated checks of the channel-by-channel occupancies and of the reference json files, but I propose to postpone this for the next PR since they require some more test and validation. Therefore this PR fully focuses on the fix of the memory leaks and the solution of the histogram merging problems we had during the pilot run. |
The memory leak was due to the fact that internal histograms of the mergeable objects were not deleted in the object's destructor. The code also reduces the number of objects published by default by the digits task. A "Diagnostic" custom parameter re-enables the publishing of the additional histograms (for experts only).
aferrero2707
force-pushed
the
mch-fix-memory-leaks-in-mergeable-histograms
branch
from
ac919d0 to
8a7caf0
Compare
Barthelemy
approved these changes
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory leak was due to the fact that internal histograms of the mergeable objects were not deleted in the object's destructor.
The code also reduces the number of objects published by default by the digits task. A "Diagnostic" custom parameter re-enables the publishing of the additional histograms (for experts only).