Skip to content

[QC-736] Set the facility after other flags are set#1027

Merged
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
Barthelemy:set-facility-qc-after-reading-config
Jan 31, 2022
Merged

[QC-736] Set the facility after other flags are set#1027
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
Barthelemy:set-facility-qc-after-reading-config

Conversation

@Barthelemy
Copy link
Copy Markdown
Collaborator

@Barthelemy Barthelemy requested a review from knopers8 as a code owner January 31, 2022 09:05
@davidrohr
Copy link
Copy Markdown
Contributor

thx!

@davidrohr
Copy link
Copy Markdown
Contributor

Unfortunately, I have no easy way to test it without having an RPM build and installing that on the EPNs.
But the fix looks so trivial, that I am 99.9% sure it is correct.
Could we have a new QC tag with this?

@Barthelemy
Copy link
Copy Markdown
Collaborator Author

Sure we can, I will release a patch version.

@Barthelemy Barthelemy merged commit 29103a9 into AliceO2Group:master Jan 31, 2022
@Barthelemy Barthelemy deleted the set-facility-qc-after-reading-config branch January 31, 2022 12:39
@Barthelemy
Copy link
Copy Markdown
Collaborator Author

Here is the patch version: https://github.com/AliceO2Group/QualityControl/releases/tag/v1.45.1
And the pr in alidist: alisw/alidist#3797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants