Skip to content

[FV0] Reenable FV0, adjust laser task to follow dataformat changes in O2#1113

Merged
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
mslupeck:master
Mar 24, 2022
Merged

[FV0] Reenable FV0, adjust laser task to follow dataformat changes in O2#1113
Barthelemy merged 1 commit into
AliceO2Group:masterfrom
mslupeck:master

Conversation

@mslupeck
Copy link
Copy Markdown
Contributor

Also unified the formatting between DigitQCTask and it's derivative: DigitQCTaskLaser

@mslupeck
Copy link
Copy Markdown
Contributor Author

Hi @sandor-lokos
I've changed the formatting of DigitQCTaksLaser so that it is easier to compare it with DigitQCTask - I hope you don't mind.
But the only difference, I could see (except change of class name), is in line 374:
// mHistAverageTimeA->Fill(digit.mTriggers.timeA);
This line is not commented in DigitQCTask. Is it intentional?

@Barthelemy Barthelemy merged commit 69e43b4 into AliceO2Group:master Mar 24, 2022
@sandor-lokos
Copy link
Copy Markdown
Contributor

Hi @mslupeck ,
I don't mind at all. In fact, I didn't even touch that file, I created the custom TH1ReductorLaser module and only copy the already existing DigitQcTask module to DigitQcTaskLaser to separate the latter from the former and leave open the way for further improvements.

Barthelemy pushed a commit that referenced this pull request Apr 1, 2022
… O2 (#1113)

Co-authored-by: Maciej Slupecki <maciej.slupecki@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants