[QC-798] Add a check to ensure entries increase every cycle#1221
Merged
Conversation
Barthelemy
force-pushed
the
add-check-nb-entries
branch
from
8bafac5 to
5e190d5
Compare
noferini
pushed a commit
to noferini/QualityControl
that referenced
this pull request
Jun 5, 2022
…roup#1221) * [QC-798] Add a check to ensure entries increase every cycle * format * reenable detectors * restore basic.json * some fixes
knopers8
reviewed
Jun 8, 2022
|
|
||
| if (previousNumberEntries == currentNumberEntries) { | ||
| result = Quality::Bad; | ||
| result.addReason(FlagReasonFactory::Unknown(), |
Collaborator
There was a problem hiding this comment.
NoDetectorData could have been used perhaps
knopers8
reviewed
Jun 8, 2022
|
|
||
| /// | ||
| /// \file IncreasingEntries.cxx | ||
| /// \author My Name |
Collaborator
There was a problem hiding this comment.
to be filled on the next occasion
Collaborator
Author
|
@knopers8 agreed, added to the ticket for the next iteration on this check: https://alice.its.cern.ch/jira/browse/QC-802 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.