[QC-854] Add templating to the discard log file#1449
Merged
Conversation
knopers8
approved these changes
Sep 14, 2022
| * @param iCtx | ||
| * @return | ||
| */ | ||
| using namespace std; |
Collaborator
There was a problem hiding this comment.
please do not use it in headers, it is going to leak out to all code in o2::quality_control::core which includes this file
Collaborator
Author
There was a problem hiding this comment.
correct, completely forgot to remove it, good catch
Collaborator
Author
|
failure unrelated. |
Barthelemy
added a commit
that referenced
this pull request
Sep 14, 2022
* [QC-854] Add templating to the discard log file * format * fix * remove redundant comment * remove include * remove include * fix * fpormat * Update runnerUtils.h * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.