Make sure the ports are unique when running the multinode test#1538
Merged
Conversation
ktf
commented
Oct 26, 2022
ktf
force-pushed
the
unique-port
branch
2 times, most recently
from
733a828 to
efa5473
Compare
Member
Author
|
Well, at least we can reproduce the issue. |
Member
Author
|
For the record, one thing I noticed on my mac is that the port is always the same... |
Collaborator
|
It is generated at cmake time, not execution time. Do you mean it is the same when running cmake over and over? |
Member
Author
|
Can we squash & merge this one and have a new release? |
Collaborator
|
@knopers8 I let you review. |
knopers8
approved these changes
Oct 31, 2022
Barthelemy
pushed a commit
that referenced
this pull request
Oct 31, 2022
* Make sure the ports are unique when running the multinode test * Update o2-qc-multinode-test.sh * update the path in curl * do not generate randomly UNIQUE_PORT_2 anymore Co-authored-by: Piotr Konopka <piotr.jan.konopka@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.