Avoid copy#1555
Merged
Merged
Conversation
This triggers some of the copies / deletions which you see.
Member
Author
|
Proper fix to avoid the copy completely coming up in the Framework. |
knopers8
approved these changes
Nov 3, 2022
Collaborator
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
I don't understand, but I trust you.
As far as I can tell, DeviceSpec does not contain any framework::Task, how does it help?
Member
Author
|
It contains the AlgorithmSpec, which contains the captured task. I am changing a few things in DPL to prevent any copy of those. |
Collaborator
|
OK, indeed, thanks |
Member
Author
|
Sorry guys, I need a patch also with this... |
Barthelemy
pushed a commit
that referenced
this pull request
Nov 7, 2022
* Avoid copy This triggers some of the copies / deletions which you see. * Update RootFileSource.cxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This triggers some of the copies / deletions which you see.