Fix timing info in ITS cluster and track tasks#1605
Merged
knopers8 merged 3 commits intoAliceO2Group:masterfrom Jan 18, 2023
Merged
Fix timing info in ITS cluster and track tasks#1605knopers8 merged 3 commits intoAliceO2Group:masterfrom
knopers8 merged 3 commits intoAliceO2Group:masterfrom
Conversation
shahor02
approved these changes
Jan 5, 2023
Collaborator
|
@ktf I am getting new errors this morning:
|
Collaborator
|
@IsakovAD Could you please review the PR? |
IsakovAD
approved these changes
Jan 18, 2023
Collaborator
IsakovAD
left a comment
IsakovAD
left a comment
There was a problem hiding this comment.
Changes are fine;
Sorry for the delay, I though that this PR already was reviewed by Ivan:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To retrieve the cluster dictionary from CCDB, the timestamp is now retrieved by using the
currenttimestamp when option0for thedicttimestampin the json is used. In this PR, we set the TF timestamp (usingTimingInfo.creation) instead of the current timestamp.Requested by reconstruction experts.
cc @chiarazampolli @shahor02