TPC: IDC task update - visualize most recent data#1640
Conversation
|
@wiechula When you have no objections, I remove the WIP. |
tklemenz
changed the title
|
The errors are unrelated. @wiechula, if everything is fine, this can be merged. |
|
@wiechula Could you approve and merge ? thank you |
|
Hi @Barthelemy, sorry for not changing the title to [WIP]. We discussed and there are a few changes that I want to make. I'll do them asap and remove the WIP again. |
tklemenz
changed the title
|
@wiechula, I made all the requested changes. Especially the |
tklemenz
changed the title
| /// Splits strings at delimiter and puts the tokens into a vector | ||
| /// \param inString String to be split | ||
| /// \param delimiter Delimiter where string should be split | ||
| std::vector<std::string> splitString(const std::string inString, const char* delimiter); |
There was a problem hiding this comment.
I think you can use
https://github.com/AliceO2Group/AliceO2/blob/dev/Common/Utils/include/CommonUtils/StringUtils.h#L110
instead
There was a problem hiding this comment.
@tklemenz , did you see this comment? I think it was not resolved, yet. If I understand correctly, you added
#include "CommonUtils/StringUtils.h"
I the cxx, but didn't replace splitString usage by https://github.com/AliceO2Group/AliceO2/blob/dev/Common/Utils/include/CommonUtils/StringUtils.h#L110 and removed splitString.
There was a problem hiding this comment.
There is tokenize in Utility.cxx line 174, which was splitString before. That should be it and works without problems.
|
Hi @Barthelemy, this can be merged now. |
3 participants
This adds the possibility for the IDC task to fetch the latest data from the ccdb regardless of the validity range and given timestamp. The functionality was moved from the temperature task to the Utility class. Therefore, the temperature task was also adjusted.
In addition, the option to exclude IDCDelta entirely from being visualized via the config file was added. The option is
doIDCDelta.