[QC-429] Introduce Timekeeper to track validity of objects#1821
Merged
Conversation
We do not propagate its results to QC objects yet, but log them instead. Once we see the logged values make sense in different setups, we can switch.
knopers8
force-pushed
the
correct-timerange-2
branch
from
05153d8 to
f7b1ca7
Compare
knopers8
commented
Jun 8, 2023
Comment on lines
+22
to
+26
| namespace o2::framework | ||
| { | ||
| struct ProcessingContext; | ||
| struct TimingInfo; | ||
| } // namespace o2::framework |
Collaborator
Author
There was a problem hiding this comment.
i should remove that
Barthelemy
approved these changes
Jun 12, 2023
Collaborator
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
very nice, thank you
| std::numeric_limits<uint32_t>::max(), std::numeric_limits<uint32_t>::min() | ||
| }; | ||
|
|
||
| class Timekeeper |
Collaborator
There was a problem hiding this comment.
you could perhaps add a word about this class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not propagate its results to QC objects yet, but log them instead. Once we see the logged values make sense in different setups, we can switch.
Until we can access DataTakingContext during initialization, we are using a naive workaround for determining the deployment mode. We are also assuming that tf has 32 orbits, which does not apply for old data.