Skip to content

ITS cluster task: Emptylane_Fraction#1832

Merged
IsakovAD merged 25 commits into
AliceO2Group:masterfrom
zz951:emptylane
Jun 30, 2023
Merged

ITS cluster task: Emptylane_Fraction#1832
IsakovAD merged 25 commits into
AliceO2Group:masterfrom
zz951:emptylane

Conversation

@zz951

@zz951 zz951 commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Empty lane fraction for IB, ML, OL and Total

@zz951 zz951 requested review from IsakovAD and iravasen as code owners June 12, 2023 15:25
Comment thread Modules/ITS/include/ITS/ITSClusterTask.h Outdated
Comment thread Modules/ITS/include/ITS/ITSClusterTask.h Outdated
Comment thread Modules/ITS/include/ITS/ITSClusterTask.h Outdated
Comment thread Modules/ITS/include/ITS/ITSClusterTask.h Outdated
Comment thread Modules/ITS/src/ITSClusterCheck.cxx Outdated
Comment thread Modules/ITS/src/ITSClusterCheck.cxx Outdated
Comment thread Modules/ITS/src/ITSClusterCheck.cxx Outdated
Comment thread Modules/ITS/src/ITSClusterTask.cxx Outdated

@IsakovAD IsakovAD left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job! I have added a couple of comments.

Could you also have a look at this code:

mLaneStatusSummaryGlobalCanvas->cd();
mLaneStatusSummaryGlobalCanvas->Clear();
TLine* mLaneStatusSummaryLine = new TLine(0, 0.1, 4, 0.1);
mLaneStatusSummaryLine->SetLineStyle(9);
mLaneStatusSummaryLine->SetLineColor(kRed);
mLaneStatusSummaryLine->SetBit(TObject::kCanDelete);
TLatex* mLaneStatusSummaryInfo = new TLatex(0.1, 0.11, Form("#bf{%s}", "Threshold value"));
mLaneStatusSummaryInfo->SetTextSize(0.05);
mLaneStatusSummaryInfo->SetTextFont(43);
mLaneStatusSummaryInfo->SetTextColor(kRed);
mLaneStatusSummaryInfo->SetBit(TObject::kCanDelete);
TH1F* mLaneStatusCanvasMember = (TH1F*)mLaneStatusSummaryGlobal->Clone("mLaneStatusCanvasMember");
mLaneStatusCanvasMember->SetBit(TObject::kCanDelete);
mLaneStatusCanvasMember->Draw("histo");
mLaneStatusSummaryLine->Draw("same");
mLaneStatusSummaryInfo->Draw("same");

Here we create and draw a TCanvas with Line and Tlatex to make plot more clear (I will send you example of figure to the mattermost)

Comment thread Modules/ITS/src/ITSClusterCheck.cxx Outdated
Comment thread Modules/ITS/src/ITSClusterTask.cxx Outdated

@IsakovAD IsakovAD left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. I have only couple of minor comments

@IsakovAD

Copy link
Copy Markdown
Collaborator

@iravasen the PR is fine from my side. Do you have any comments?

@iravasen iravasen changed the title [WIP]Emptylane_Fraction Emptylane_Fraction Jun 26, 2023
@iravasen iravasen changed the title Emptylane_Fraction ITS cluster task: Emptylane_Fraction Jun 26, 2023
@IsakovAD IsakovAD merged commit 368fc27 into AliceO2Group:master Jun 30, 2023
@zz951 zz951 deleted the emptylane branch June 30, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants