ITS cluster task: Emptylane_Fraction#1832
Merged
Merged
Conversation
IsakovAD
reviewed
Jun 13, 2023
IsakovAD
reviewed
Jun 13, 2023
IsakovAD
reviewed
Jun 13, 2023
IsakovAD
reviewed
Jun 13, 2023
IsakovAD
reviewed
Jun 13, 2023
IsakovAD
reviewed
Jun 13, 2023
IsakovAD
reviewed
Jun 13, 2023
IsakovAD
reviewed
Jun 13, 2023
IsakovAD
requested changes
Jun 13, 2023
IsakovAD
left a comment
Collaborator
There was a problem hiding this comment.
Very nice job! I have added a couple of comments.
Could you also have a look at this code:
QualityControl/Modules/ITS/src/ITSFeeTask.cxx
Lines 483 to 502 in 9c9a6c5
Here we create and draw a TCanvas with Line and Tlatex to make plot more clear (I will send you example of figure to the mattermost)
added 3 commits
June 13, 2023 15:38
IsakovAD
reviewed
Jun 15, 2023
IsakovAD
reviewed
Jun 15, 2023
IsakovAD
reviewed
Jun 15, 2023
IsakovAD
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the changes. I have only couple of minor comments
added 2 commits
June 15, 2023 14:26
Collaborator
|
@iravasen the PR is fine from my side. Do you have any comments? |
iravasen
approved these changes
Jun 26, 2023
IsakovAD
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty lane fraction for IB, ML, OL and Total